Skip to content

Conversation

jhaigh0
Copy link
Contributor

@jhaigh0 jhaigh0 commented Nov 14, 2024

Description of work

Just chipping away at the cppcheck backlog.
I have looked at the history for each of these cases to check their usage was not removed in error. In all cases they were either added and never used, or had their usage removed intentionally but the definition left behind my mistake.

Also, some other ccpcheck suppressions were disrupted, so i've fixed those too.

There is no associated issue.

To test:

  • ci passes
  • check I haven't done anything stupid

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@jhaigh0 jhaigh0 added the ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions label Nov 14, 2024
@jhaigh0 jhaigh0 added this to the Release 6.12 milestone Nov 14, 2024
@robertapplin robertapplin self-assigned this Nov 14, 2024
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm these changes look good. Its nice to see a bunch of unused code being removed!

@SilkeSchomann SilkeSchomann self-assigned this Nov 15, 2024
@SilkeSchomann SilkeSchomann merged commit 78943b8 into main Nov 15, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the unread_variable_cppcheck branch November 15, 2024 09:50
peterfpeterson pushed a commit to peterfpeterson/mantid that referenced this pull request Nov 26, 2024
This brings mantidproject#38397 into ornl-next

constVariablePointer cppcheck fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants