Some unusedVariiable cppckeck error removals.

Framework/API/src/NumericAxis.cpp

@@ -163,7 +163,7 @@ std::string NumericAxis::formatLabel(const double value) const {
     if (*it == '0') {
       it = numberLabel.erase(it);
     } else if (*it == '.') {
-      it = numberLabel.erase(it);
+      numberLabel.erase(it);
       break;
     } else {
       break;

Framework/Algorithms/src/CalculateCarpenterSampleCorrection.cpp

@@ -159,8 +159,6 @@ void CalculateCarpenterSampleCorrection::exec() {
   // Initialize progress reporting.
   Progress prog(this, 0.0, 1.0, NUM_HIST);
 
-  EventWorkspace_sptr inputWkspEvent = std::dynamic_pointer_cast<EventWorkspace>(inputWksp);
-
   // Create the new correction workspaces
   MatrixWorkspace_sptr absWksp = createOutputWorkspace(inputWksp, "Attenuation factor");
   MatrixWorkspace_sptr msWksp = createOutputWorkspace(inputWksp, "Multiple scattering factor");

Framework/Algorithms/src/GroupWorkspaces.cpp

@@ -58,7 +58,6 @@ std::map<std::string, std::string> GroupWorkspaces::validateInputs() {
   std::map<std::string, std::string> results;
   const std::vector<std::string> inputWorkspaces = getProperty("InputWorkspaces");
   std::string globExpression = getProperty("GlobExpression");
-  std::string outputWorkspace = getProperty("OutputWorkspace");
 
   for (auto it = globExpression.begin(); it < globExpression.end(); ++it) {
     if (*it == '\\') {

Framework/Algorithms/src/InterpolatingRebin.cpp

@@ -66,7 +66,7 @@ std::map<std::string, std::string> InterpolatingRebin::validateInputs() {
   MatrixWorkspace_sptr inputWS = getProperty("InputWorkspace");
   std::vector<double> rbParams = getProperty("Params");
   try {
-    std::vector<double> validParams = Rebin::rebinParamsFromInput(rbParams, *inputWS, g_log);
+    Rebin::rebinParamsFromInput(rbParams, *inputWS, g_log);
   } catch (std::exception &err) {
     helpMessages["Params"] = err.what();
   }

Framework/Algorithms/src/SmoothNeighbours.cpp

@@ -314,7 +314,6 @@ void SmoothNeighbours::findNeighboursUbiquitous() {
   m_progress->resetNumSteps(m_inWS->getNumberHistograms(), 0.2, 0.5);
   this->progress(0.2, "Building Neighbour Map");
 
-  Instrument_const_sptr inst = m_inWS->getInstrument();
   const spec2index_map spec2index = m_inWS->getSpectrumToWorkspaceIndexMap();
 
   // Resize the vector we are setting
@@ -379,7 +378,7 @@ void SmoothNeighbours::findNeighboursUbiquitous() {
     std::vector<weightedNeighbour> neighbours;
 
     // Convert from spectrum numbers to workspace indices
-    for (auto &specDistance : neighbSpectra) {
+    for (const auto &specDistance : neighbSpectra) {
       specnum_t spec = specDistance.first;
 
       // Use the weighting strategy to calculate the weight.

Framework/Algorithms/src/Stitch.cpp

@@ -26,7 +26,6 @@ using namespace Mantid::Kernel;
 namespace {
 static const std::string INPUT_WORKSPACE_PROPERTY = "InputWorkspaces";
 static const std::string REFERENCE_WORKSPACE_PROPERTY = "ReferenceWorkspace";
-static const std::string COMBINATION_BEHAVIOUR_PROPERTY = "CombinationBehaviour";
 static const std::string SCALE_FACTOR_CALCULATION_PROPERTY = "ScaleFactorCalculation";
 static const std::string MANUAL_SCALE_FACTORS_PROPERTY = "ManualScaleFactors";
 static const std::string TIE_SCALE_FACTORS_PROPERTY = "TieScaleFactors";
@@ -241,8 +240,6 @@ void Stitch::init() {
                   "that is, the one that will not be scaled. If left blank, "
                   "stitching will be performed left to right in the order of x-axes ascending, "
                   "no matter the order of workspaces names in the input.");
-  declareProperty(COMBINATION_BEHAVIOUR_PROPERTY, "Interleave",
-                  std::make_unique<ListValidator<std::string>>(std::array<std::string, 1>{"Interleave"}));
   declareProperty(SCALE_FACTOR_CALCULATION_PROPERTY, "MedianOfRatios",
                   std::make_unique<ListValidator<std::string>>(std::array<std::string, 2>{"MedianOfRatios", "Manual"}));
   declareProperty(std::make_unique<ArrayProperty<double>>(MANUAL_SCALE_FACTORS_PROPERTY),
@@ -264,7 +261,6 @@ void Stitch::init() {
  */
 void Stitch::exec() {
   const auto referenceName = getPropertyValue(REFERENCE_WORKSPACE_PROPERTY);
-  const auto combinationBehaviour = getPropertyValue(COMBINATION_BEHAVIOUR_PROPERTY);
   const auto scaleFactorCalculation = getPropertyValue(SCALE_FACTOR_CALCULATION_PROPERTY);
   const auto inputs = RunCombinationHelper::unWrapGroups(getProperty(INPUT_WORKSPACE_PROPERTY));
   MatrixWorkspace_sptr scaleFactorsWorkspace;

Framework/Algorithms/src/WeightedMeanOfWorkspace.cpp

@@ -60,10 +60,9 @@ void WeightedMeanOfWorkspace::exec() {
         continue;
     auto &y = inputWS->y(i);
     auto &e = inputWS->e(i);
-    double weight = 0.0;
     for (std::size_t j = 0; j < y.size(); ++j) {
       if (std::isfinite(y[j]) && std::isfinite(e[j])) {
-        weight = 1.0 / (e[j] * e[j]);
+        double weight = 1.0 / (e[j] * e[j]);
         averageValue += (y[j] * weight);
         weightSum += weight;
       }

Framework/Crystal/src/GoniometerAnglesFromPhiRotation.cpp

@@ -303,7 +303,6 @@ void GoniometerAnglesFromPhiRotation::exec() {
   double deg, ax1, ax2, ax3;
   Q1.getAngleAxis(deg, ax1, ax2, ax3);
   if (dphi * deg < 0) {
-    deg = -deg;
     ax1 = -ax1;
     ax2 = -ax2;
     ax3 = -ax3;

Framework/DataHandling/src/LoadANSTOHelper.cpp

@@ -432,15 +432,13 @@ bool File::append(const std::string &path, const std::string &name, const void *
     else if (targetPosition != -1)
       throw std::runtime_error("format exception"); // it has to be the last file in the archive
 
-    FileInfo fileInfo;
-    fileInfo.Offset = position;
-    fileInfo.Size = header.readFileSize();
+    auto fileSize = header.readFileSize();
 
-    auto offset = static_cast<size_t>(fileInfo.Size % 512);
+    auto offset = static_cast<size_t>(fileSize % 512);
     if (offset != 0)
       offset = 512 - offset;
 
-    fileStatus &= 0 == fseek(handle.get(), static_cast<long>(fileInfo.Size + offset), SEEK_CUR);
+    fileStatus &= 0 == fseek(handle.get(), static_cast<long>(fileSize + offset), SEEK_CUR);
   }
 
   if (targetPosition < 0)

Framework/DataHandling/src/LoadTBL.cpp

@@ -160,7 +160,7 @@ void LoadTBL::csvParse(const std::string &line, std::vector<std::string> &cols,
           firstCell = false;
         } else {
           auto colVal = line.substr(lastComma + 1, pos - (lastComma + 1));
-          cols.emplace_back(line.substr(lastComma + 1, pos - (lastComma + 1)));
+          cols.emplace_back(colVal);
         }
       }
       lastComma = pos;

Framework/DataHandling/src/SavePHX.cpp

@@ -46,9 +46,6 @@ void SavePHX::exec() {
   // Retrieve the filename from the properties
   const std::string filename = getProperty("Filename");
 
-  // Get a pointer to the sample
-  IComponent_const_sptr sample = inputWorkspace->getInstrument()->getSample();
-
   std::ofstream outPHX_file(filename.c_str());
 
   if (!outPHX_file) {
@@ -74,7 +71,7 @@ void SavePHX::exec() {
                     }*/
   spCalcDetPar->execute();
   //
-  auto *pCalcDetPar = dynamic_cast<FindDetectorsPar *>(spCalcDetPar.get());
+  const auto *pCalcDetPar = dynamic_cast<FindDetectorsPar *>(spCalcDetPar.get());
   if (!pCalcDetPar) { // "can not get pointer to FindDetectorsPar algorithm"
     throw(std::bad_cast());
   }

Framework/Kernel/src/LogFilter.cpp

@@ -89,10 +89,6 @@ void LogFilter::addFilter(const TimeSeriesProperty<bool> &filter) {
   } else {
     // determine if the current version of things are open-ended
     filterOpenEnded = (m_filter->lastValue() && filter.lastValue());
-    DateAndTime firstTime = std::min(m_filter->firstTime(), filter.firstTime());
-    if (m_prop && (m_prop->size() > 0)) {
-      firstTime = std::min(firstTime, m_prop->firstTime());
-    }
 
     // create a local copy of both filters to add extra values to
     auto filter1 = m_filter.get();

Framework/LiveData/src/ISIS/DAE/isisds_command.cpp

@@ -313,7 +313,6 @@ static int isisds_recv_command_helper(SOCKET s, char **command, void **data, ISI
       free(*data);
       *data = nullptr;
     }
-    len_data = 0;
     return -1;
   }
   /* only update values if changed ... allows Read only parameters to be passed

buildconfig/CMake/CppCheck_Suppressions.txt.in

@@ -60,7 +60,6 @@ constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Kernel/src/EnabledWhenPropert
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Kernel/src/EnabledWhenProperty.cpp:151
 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/Kernel/src/DiskBuffer.cpp:363
 iterateByValue:${CMAKE_SOURCE_DIR}/Framework/Kernel/src/MultiFileValidator.cpp:65
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Kernel/src/LogFilter.cpp:94
 nullPointerRedundantCheck:${CMAKE_SOURCE_DIR}/Framework/Kernel/src/InternetHelper.cpp:148
 nullPointerRedundantCheck:${CMAKE_SOURCE_DIR}/Framework/Kernel/src/InternetHelper.cpp:149
 nullPointerRedundantCheck:${CMAKE_SOURCE_DIR}/Framework/Kernel/src/InternetHelper.cpp:150
@@ -165,7 +164,6 @@ knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/AbsorptionC
 knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/AbsorptionCorrection.cpp:445
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/CalculateEfficiency.cpp:158
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/CalculateEfficiency.cpp:159
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/CalculateCarpenterSampleCorrection.cpp:162
 missingOverride:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/SpectrumAlgorithm.h:97
 returnByReference:${CMAKE_SOURCE_DIR}/Framework/API/inc/MantidAPI/FunctionDomain1D.h:89
 returnByReference:${CMAKE_SOURCE_DIR}/Framework/API/inc/MantidAPI/FunctionValues.h:86
@@ -211,7 +209,6 @@ constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/EQSANSTofStruc
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/EQSANSTofStructure.cpp:81
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FilterByLogValue.cpp:82
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/EstimateResolutionDiffraction.cpp:188
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GroupWorkspaces.cpp:61
 uninitMemberVarPrivate:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/FindPeaksConvolve.h:62
 uninitMemberVarPrivate:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/FindPeaksConvolve.h:63
 uninitMemberVarPrivate:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/FindPeaksConvolve.h:64
@@ -241,7 +238,6 @@ constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GeneratePeak
 shadowVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/He3TubeEfficiency.cpp:374
 knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FindPeaks.cpp:892
 knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/FindPeaks.cpp:999
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/InterpolatingRebin.cpp:69
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GetEi2.cpp:213
 missingOverride:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/GetAllEi.h:32
 passedByValue:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/GetTimeSeriesLogInformation.cpp:277
@@ -307,13 +303,10 @@ constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/ShiftLogTime.c
 constParameterPointer:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/SofQCommon.cpp:25
 containerOutOfBounds:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/SampleCorrections/SparseWorkspace.cpp:32
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/SpatialGrouping.cpp:214
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/Stitch.cpp:267
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/UpdateScriptRepository.cpp:51
 uselessOverride:${CMAKE_SOURCE_DIR}/Framework/Algorithms/inc/MantidAlgorithms/SofQWPolygon.h:55
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/AlgorithmHasProperty.cpp:36
-constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/SmoothNeighbours.cpp:382
 cstyleCast:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/SumEventsByLogValue.cpp:409
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/SmoothNeighbours.cpp:317
 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/Stitch1DMany.cpp:291
 missingOverride:${CMAKE_SOURCE_DIR}/Framework/API/inc/MantidAPI/IAlgorithmRuntimeProps.h:16
 missingOverride:${CMAKE_SOURCE_DIR}/Framework/API/inc/MantidAPI/AlgorithmRuntimeProps.h:21
@@ -353,11 +346,9 @@ constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IPeaksWorkspace.cpp:5
 knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/API/src/FunctionFactory.cpp:267
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/ITableWorkspace.cpp:118
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IMDHistoWorkspace.cpp:54
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Algorithms/src/WeightedMeanOfWorkspace.cpp:63
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/API/src/IMDEventWorkspace.cpp:50
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IMDEventWorkspace.cpp:85
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/IMDEventWorkspace.cpp:92
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/API/src/NumericAxis.cpp:166
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/API/src/ParameterReference.cpp:52
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/API/src/MultiDomainFunction.cpp:135
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/API/src/MultiDomainFunction.cpp:174
@@ -435,7 +426,6 @@ constParameterReference:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/PeakStatistics
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/CentroidPeaks.cpp:75
 passedByValue:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/LoadIsawSpectrum.cpp:190
 passedByValue:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/LoadIsawSpectrum.cpp:191
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/GoniometerAnglesFromPhiRotation.cpp:306
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/FindSXPeaks.cpp:223
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/SelectCellWithForm.cpp:134
 nullPointerRedundantCheck:${CMAKE_SOURCE_DIR}/Framework/Crystal/src/PredictSatellitePeaks.cpp:95
@@ -609,7 +599,6 @@ uselessOverride:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandlin
 passedByValue:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/BitStream.h:30
 cstyleCast:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadANSTOHelper.cpp:210
 variableScope:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/DetermineChunking.cpp:163
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadANSTOHelper.cpp:436
 uselessCallsSubstr:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadFITS.cpp:547
 uninitMemberVarPrivate:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadHFIRSANS.h:124
 uninitMemberVarPrivate:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadHFIRSANS.h:125
@@ -675,7 +664,6 @@ constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadMuonN
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadMuonNexus2.cpp:148
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadMuonNexus2.cpp:486
 constParameterReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadTBL.cpp:133
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadTBL.cpp:162
 constVariableReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/LoadPreNexus.cpp:244
 returnByReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadSpiceXML2DDet.h:30
 returnByReference:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/LoadSpiceXML2DDet.h:31
@@ -732,8 +720,6 @@ knownConditionTrueFalse:${CMAKE_SOURCE_DIR}/Framework/DataObjects/src/CoordTrans
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataObjects/src/CoordTransformAffine.cpp:277
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataObjects/src/CoordTransformAffine.cpp:357
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataObjects/src/CoordTransformAffine.cpp:368
-constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SavePHX.cpp:77
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SavePHX.cpp:50
 missingOverride:${CMAKE_SOURCE_DIR}/Framework/DataHandling/inc/MantidDataHandling/SaveOpenGenieAscii.h:23
 passedByValue:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveNXcanSAS.cpp:412
 passedByValue:${CMAKE_SOURCE_DIR}/Framework/DataHandling/src/SaveNXcanSAS.cpp:428
@@ -864,7 +850,6 @@ invalidPointerCast:${CMAKE_SOURCE_DIR}/Framework/LiveData/inc/MantidLiveData/ADA
 invalidPointerCast:${CMAKE_SOURCE_DIR}/Framework/LiveData/inc/MantidLiveData/ADARA/ADARAPackets.h:679
 cstyleCast:${CMAKE_SOURCE_DIR}/Framework/LiveData/src/ISIS/DAE/isisds_command.cpp:170
 constVariablePointer:${CMAKE_SOURCE_DIR}/Framework/LiveData/src/ISIS/DAE/isisds_command.cpp:126
-unreadVariable:${CMAKE_SOURCE_DIR}/Framework/LiveData/src/ISIS/DAE/isisds_command.cpp:316
 badBitmaskCheck:${CMAKE_SOURCE_DIR}/Framework/LiveData/inc/MantidLiveData/ISIS/TCPEventStreamDefs.h:70
 unsignedPositive:${CMAKE_SOURCE_DIR}/Framework/LiveData/inc/MantidLiveData/ISIS/TCPEventStreamDefs.h:61
 identicalInnerCondition:${CMAKE_SOURCE_DIR}/Framework/LiveData/src/ADARA/ADARAPackets.cpp:220
@@ -1129,9 +1114,6 @@ constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/AlgorithmDialog.c
 constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/AlgorithmDialog.cpp:902
 constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/AlgorithmDialog.cpp:904
 returnByReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/inc/MantidQtWidgets/Common/AlgorithmPropertiesWidget.h:50
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/AlgorithmPropertiesWidget.cpp:299
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/AlgorithmPropertiesWidget.cpp:404
-unreadVariable:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/AlgorithmPropertiesWidget.cpp:294
 returnByReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/inc/MantidQtWidgets/Common/AlgorithmSelectorWidget.h:45
 missingOverride:${CMAKE_SOURCE_DIR}/qt/widgets/common/inc/MantidQtWidgets/Common/ConfiguredAlgorithm.h:19
 returnByReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/inc/MantidQtWidgets/Common/BatchAlgorithmRunner.h:73
@@ -1220,16 +1202,8 @@ virtualCallInConstructor:${CMAKE_SOURCE_DIR}/qt/widgets/common/inc/MantidQtWidge
 returnByReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/inc/MantidQtWidgets/Common/ScriptEditor.h:63
 constVariableReference:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/ScriptRepositoryView.cpp:113
 constParameterPointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:107
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:394
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:634
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:674
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:698
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:711
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:728
-constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:966
+constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:960
 unassignedVariable:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:50
-unreadVariable:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:506
-unreadVariable:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/RepoModel.cpp:514
 constVariablePointer:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/TextPropertyWidget.cpp:39
 virtualCallInConstructor:${CMAKE_SOURCE_DIR}/qt/widgets/common/inc/MantidQtWidgets/Common/FunctionTreeView.h:107
 useStlAlgorithm:${CMAKE_SOURCE_DIR}/qt/widgets/common/src/FunctionTreeView.cpp:974