Import externally generated files on Muon ALC interface #38398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertapplin
added
Muon
|
I will send this package to Adam Berlie for testing: |
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @robertapplin, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
robertapplin
force-pushed
the
38353-load-external-files-on-muon-alc
branch
from
e0f2ee6 to
9cb74c8
Compare
robertapplin
removed
the
Has Conflicts
robertapplin
force-pushed
the
38353-load-external-files-on-muon-alc
branch
from
9cb74c8 to
1be816f
Compare
|
Adam is happy with the changes: |
|
Followed the given test instructions and they work as expected. If @robertapplin could check the comments above it would be great. |
robertapplin
force-pushed
the
38353-load-external-files-on-muon-alc
branch
from
1be816f to
2674316
Compare
warunawickramasingha
approved these changes
Dec 9, 2024
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Jan 16, 2025
This is a squashed version of mantidproject#38398 Ability to import external data into Muon ALC interface Add release note Remove signal from ALCDataHandlingView Add unit test for calling subscriber method Rename subscribe method to setSubscriber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report to: Adam Berlie
Description of work
This PR makes it possible to import a workspace from the ADS into the Muon ALC interface if it has 1 histogram. The data can be loaded into Mantid from a *.dat or *.txt file for example, and then imported into the Muon ALC interface as long as its a matrix workspace.
Fixes #38353
To test:
Load the following data into workbench
QLCR150K.zip
Open
Muon->ALCinterfaceClick
Import results...in the bottom leftEnter the name of the workspace you loaded and click Okay
The plot should be populated with the data
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.