Skip to content

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Nov 15, 2024

Previously it was pinned to v0.2.7 and this moves it to v0.4.7.

There is no associated issue.

To test:

The new version should still pass all the tests.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@peterfpeterson peterfpeterson added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Nov 15, 2024
@peterfpeterson peterfpeterson added this to the Release 6.12 milestone Nov 15, 2024
@sf1919
Copy link
Contributor

sf1919 commented Nov 18, 2024

Looks like the release note in Powder Diffraction is not in a sub-folder so it's not being picked up.

@peterfpeterson peterfpeterson added Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction labels Nov 18, 2024
@peterfpeterson peterfpeterson marked this pull request as ready for review November 18, 2024 14:22
Copy link
Contributor

@KedoKudo KedoKudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@AndreiSavici AndreiSavici merged commit 6b9ee70 into mantidproject:main Nov 18, 2024
10 checks passed
@peterfpeterson peterfpeterson deleted the pystog_v047 branch November 18, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction Maintenance Unassigned issues to be addressed in the next maintenance period. Powder Issues and pull requests related to powder diffraction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants