Move H5Util file to Mantid::Nexus library
#38406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertapplin
added
Maintenance
robertapplin
force-pushed
the
38332-move-nexus-reading-code-to-nexus-library
branch
from
0a76c8b to
4431232
Compare
robertapplin
force-pushed
the
38332-move-nexus-reading-code-to-nexus-library
branch
from
4431232 to
9581ac8
Compare
martyngigg
requested changes
Nov 19, 2024
robertapplin
force-pushed
the
38332-move-nexus-reading-code-to-nexus-library
branch
5 times, most recently
from
a695487 to
29baa8f
Compare
robertapplin
force-pushed
the
38332-move-nexus-reading-code-to-nexus-library
branch
from
29baa8f to
f39c5c2
Compare
martyngigg
approved these changes
Nov 21, 2024
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Nov 21, 2024
This is a squashed version of mantidproject#38406 Move H5Util file to Framework/Nexus library Remove unused includes and add where appropriate Fix cppcheck warnings in loading code
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR moves the
H5Utilfiles from the Mantid::DataHandling library to Mantid::Nexus because it is used for loading nexus data using the H5Cpp library. This PR also removes a couple of unused includes in some of the Mantid::Nexus library files.Part of #38332
To test:
Mainly code review. Tests should pass.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.