Elwin Interface Sync into ornl-next #38419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpatrou
force-pushed
the
label_output_workspaces_ornl
branch
from
d8e4dab to
bd7c6d2
Compare
mpatrou
changed the title
mpatrou
force-pushed
the
label_output_workspaces_ornl
branch
2 times, most recently
from
a03e0b0 to
b5c8960
Compare
This is a squashed version of #37901 Add test for IqtPresenter, and mocks for Iqtmodel and view Eliminate unused funciton in IqtPresenter Remove unnecesary virtual functions override data processor destructor to make it virtual
This is a squashed version of #38033 Set Y axis to SpectraAxis if not a SpectraAxis originally Add test for ElasticWindowMultiple with ISIS data Add test for ElasticWindowMultiple with ILL data Refactor ElasticWindowMultiple system test to re-use code Only convert spectrum axis if detector count is non-zero
mpatrou
force-pushed
the
label_output_workspaces_ornl
branch
from
b5c8960 to
4741bdc
Compare
This is a squashed version of #38119 new signal/slot syntax changed on QENSFitting update signals/slots in processor and corrections interfaces new signal/slots on bayes fitting interface QComboBox::currentIndexChanged(QString &) was found to be deprecated, it is changed to QComboBox::currentIndexChanged(int) in the affected instances remove accidental includes
This is a squashed version of #38274 Add failure case to DataProcessor moments manual testing Do not enable plot spectra indices text edit Refactor SofQWMoments to not use the ADS as much during processing Avoid using ADS when processing Moments tab algorithm Add class for mocking an IAlgorithm in tests Add tests for MomentsPresenter::runComplete function Pass const algorithm smart pointer to runComplete
… class. This is a squashed version of #38289 Refactor setOutputPlotOptionsPresenter to create model and pass it to the construtor of the OutputPlotOptionsPresenter Pass parameters to initialize OutputPlotOptions from relevant interfaces Remove unnecesary constructor from the presenter Move OPPresenter out of the derived interface classes and into the InelasticTab class Add virtual destructor and override specifier in OPPresenter
This is a squashed version of #37762 Add new output name widget class and gui to add custom output labels to workspace output names in inelastic interfaces Refactor elwin model to update the output workspace names in a different function call and not on the final call to setup elwin algo Use label widget to manage output name workspaces from presenter class Create function to retrieve raw pointer to output name widget, which is held by ElwinView widget, and update tab specific suffixes on the output name widget Add custom output name widget to GUI Refactor elwin model and presenter test to work with changes after using output name widget, also create mock class for output name widget Change layout of the output widget Update allowed suffices on output widget when suffix settings are changed from indirect settings Fix clang format Fix problems in tests after rebase with main Remove reference to ADS in warning label Replace function to update label name after last sprint elwin class modifications Change label abbreviation and use new signal/slot syntax Rename function for adding underscore to hopefully clearer name Reimplemenet overriden suffix function to update the label if output suffices restrictions are changed from settings Split outputname widget class into view and presenter Modify Data processor class and elwin to construct a outputname Add tests for OutputNamePresenter remove empty anonymous namespace Simplify function to find index where to insert the label, rename explicit cast size_t to int to avoid test warning Reformat files after rebase Add model for the output name widget Initialize outputname widget with model and move it to the parent inelastic tab class Add tests for OutputNameModel refactor presenter tests and add mocks for the output name model Improve layout visual aspects and consistency accross OS. Add tooltip for the label TextEdit to indicate how the widget operates fix typo in ui
This is a squashed version of #38357 Add ResNormPresenter Add Resnorm view and model Refactor BayesFitting class to initiate ResNorm as MVP Add Selector utility functions to interface utils reformat ResNormView file slightly: Prune presenter-view interactions Return log struct vectors by constant reference Set energy settings input parameter as constant double value Dont add the presnter and the model as MOC files Properly add bayes include variable files to parent scope's target
This is a squashed version of #38391 Remove deprecated Calculate Paalman Pings tab Remove interface documentation for deprecated Paalman Pings feature Add release note for removing paalman pings tab
mpatrou
force-pushed
the
label_output_workspaces_ornl
branch
from
2f740bc to
3f7f2f2
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Elwin related and other PRs to ornl-next
It includes:
Summary of work
Fixes #xxxx.
Further detail of work
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.