Move from matplotlib 3.8 to 3.9 #38435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
force-pushed
the
matplotlib_3_9
branch
from
a12beb7 to
802f2a1
Compare
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @peterfpeterson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
peterfpeterson
force-pushed
the
matplotlib_3_9
branch
from
802f2a1 to
bc5e77a
Compare
peterfpeterson
removed
the
Has Conflicts
The other checks that the 3d view is cubic remain
peterfpeterson
force-pushed
the
matplotlib_3_9
branch
from
bc5e77a to
e512861
Compare
Change listed in mpl 3.9 release notes https://matplotlib.org/3.9.0/api/prev_api_changes/api_changes_3.9.0.html#line2d
jclarkeSTFC
requested changes
Nov 26, 2024
jclarkeSTFC
approved these changes
Nov 26, 2024
peterfpeterson
added
the
Maintenance
peterfpeterson
added a commit
to peterfpeterson/mantid
that referenced
this pull request
Nov 26, 2024
This is a squash of mantidproject#38435 Modify test that bounding box is bigger than the shape The other checks that the 3d view is cubic remain Fix IntegratePeaksSkew 'x must be a sequence' Change listed in mpl 3.9 release notes https://matplotlib.org/3.9.0/api/prev_api_changes/api_changes_3.9.0.html#line2d Update release note to include link for matplotlib 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the move to numpy v2 in #38420, we can move to the latest stable of release of matplotlib. According to the matplotlib 3.9 notes on runtime dependencies, qt5 is still supported. Let's see what happens.
Link to changes in matplotlib 3.9
There is no associated issue but this is associated with EWM8431
To test:
Probably should do some quick testing of things that rely on matplotlib like SliceViewer, otherwise if the tests pass it should be good to go.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.