clang18, coverity, and matplotlib 3.9 changes into ornl-next #38450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings mantidproject#38342 into ornl-next In Clang 17 a new optimisation was introduced that breaks some of our tests, e.g. SplineSmoothingTest, so I've disabled that option. Use smart pointers instead of raw pointers Disable compiler extensions This should give us more consistent behaviour across different compilers.
This gets the changes from mantidproject#38142 into ornl-next Most fixes were for copying in instead of moving in to a method that I've recently added to fix Coverity warnings about null objects. The changes in FindPeaksConvolve were because m_pdf was being either read or written to without the lock. Refactor to avoid potential null cast This refactor will protect against a null cast in the case of a non-MultiDomainFunction being passed in.
peterfpeterson
added
Maintenance
This brings mantidproject#38397 into ornl-next constVariablePointer cppcheck fixes
This is a squashed version of mantidproject#38092 Release notes added
peterfpeterson
force-pushed
the
38335_clang_18_ornlnext
branch
from
567f040 to
33e797e
Compare
This is a squash of mantidproject#38435 Modify test that bounding box is bigger than the shape The other checks that the 3d view is cubic remain Fix IntegratePeaksSkew 'x must be a sequence' Change listed in mpl 3.9 release notes https://matplotlib.org/3.9.0/api/prev_api_changes/api_changes_3.9.0.html#line2d Update release note to include link for matplotlib 3.9
peterfpeterson
changed the title
This is a squashed versino of mantidproject#38299 Moved mslice from mantid to mantidworkbench recipe Add mantid channel to conda build command Only pass channel to mantid-developer and mantidworkbench Removed quotation marks from channel option Added space after debug option back Use classic solver with mamba Corrected solver argument Install classic solver Add mantid channel via conda config Add conda-forge after mantid for higher priority Use Mslice with seperate_mslice_test label Updated copyright year Only install mslice for workbench Added release note Use mantid/label/main instead of mantid Updated installers and pinned mslice to 2.10 Check for correct MSlice version before building release of Mantid Updated mslice interface Update dev-docs/source/ReleaseChecklist.rst Co-authored-by: Jonathan Haigh <35813666+jhaigh0@users.noreply.github.com> Update installers/conda/win/create_package.sh Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk>
peterfpeterson
merged commit 990db36
into
mantidproject:ornl-next
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the following changes into
ornl-next