Skip to content

Conversation

jclarkeSTFC
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC commented Nov 27, 2024

Running this test with your computer set to a non-UTC time zone will result in a different output, because the time is written out in local time. Hence we have to adjust our expected output.

To test:

Tests should pass

If you want to experience the test failing, then on Linux you can set the TZ environment variable to e.g. Asia/Singapore, then run the test. On Windows you will need to change your system time zone, which you can do e.g. from a command prompt with tzutil /s "Pacific Standard Time", (don't forget to change it back).

This does not require release notes because it's only a change to test code.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

Running this test with your computer set to a non-UTC time zone will
result in a different output, because the time is written out in
local time. Hence we have to adjust our expected output.
@jclarkeSTFC jclarkeSTFC added Reflectometry Issues and pull requests related to reflectometry ISIS: LSS Issue and pull requests relating to SANS and Reflectometry (Large Scale Structures) at ISIS labels Nov 27, 2024
@jclarkeSTFC jclarkeSTFC added this to the Release 6.12 milestone Nov 27, 2024
@AndreiSavici
Copy link
Member

Works as expected

@jclarkeSTFC jclarkeSTFC marked this pull request as ready for review November 28, 2024 08:38
@rbauststfc rbauststfc self-assigned this Nov 28, 2024
Copy link
Contributor

@rbauststfc rbauststfc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Andrei has confirmed that the test is now passing for him and it's also passing our CI tests, which are in a different time zone, so this fix looks good. Thanks very much @jclarkeSTFC for looking at this one!

@adriazalvarez, if you're planning to make changes to this test class for the issue you're working on at the moment then you might want to update your branch once this is merged in to avoid any potential merge conflicts.

@SilkeSchomann SilkeSchomann self-assigned this Nov 28, 2024
@SilkeSchomann SilkeSchomann merged commit c577f4a into main Nov 28, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the timezone_reflectometry_test branch November 28, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: LSS Issue and pull requests relating to SANS and Reflectometry (Large Scale Structures) at ISIS Reflectometry Issues and pull requests related to reflectometry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants