Skip to content

Conversation

cailafinn
Copy link
Contributor

Description of work

Summary of work

Breaking change to HTTPSClientSession in latest Poco version. Pin it to stop this happening.

https://raw.githubusercontent.com/pocoproject/poco/poco-1.14.0-release/CHANGELOG

There is no associated issue.

To test:

  1. Builds should complete successfully on all OSs.

This does not require release notes because **there are no user-facing changes. **


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

Breaking change to HTTPSClientSession in latest Poco version.
@cailafinn cailafinn added Framework Issues and pull requests related to components in the Framework DevOps Issues and pull requests related to DevOps labels Dec 2, 2024
@cailafinn cailafinn added this to the Release 6.12 milestone Dec 2, 2024
@cailafinn cailafinn marked this pull request as ready for review December 2, 2024 10:54
@SilkeSchomann SilkeSchomann self-assigned this Dec 2, 2024
@sf1919 sf1919 self-assigned this Dec 2, 2024
@sf1919 sf1919 added the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label Dec 2, 2024
Copy link
Contributor

@SilkeSchomann SilkeSchomann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that all tests pass with the new pin for poco.

@sf1919 sf1919 merged commit 1beb5cf into main Dec 2, 2024
10 checks passed
@sf1919 sf1919 deleted the pin_poco branch December 2, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Issues and pull requests related to DevOps Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants