Skip to content

Conversation

RichardWaiteSTFC
Copy link
Contributor

Description of work

Correct typo in default workspace name produced by pearl powder reduction with focus_mode="trans" introduced by #38344

There is no associated issue.

Report to: Nick Funnell (PEARL)

To test:

Follow instructions in #38344

This does not require release notes because bug introduced this release

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@RichardWaiteSTFC RichardWaiteSTFC added Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction ISIS: Diffraction Issue and pull requests relating to Diffraction at ISIS labels Jan 2, 2025
@RichardWaiteSTFC RichardWaiteSTFC added this to the Release 6.12 milestone Jan 2, 2025
@robertapplin robertapplin self-assigned this Jan 3, 2025
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, and apologies I didn't spot this previously! I followed the instructions and its working as described

No release note required because this bug was introduced after the previous stable release

@RichardWaiteSTFC
Copy link
Contributor Author

Thanks for fixing this, and apologies I didn't spot this previously! I followed the instructions and its working as described

Thanks for quick review - no need to apologise it was my fault!

@thomashampson thomashampson self-assigned this Jan 3, 2025
@thomashampson thomashampson merged commit 22bed21 into main Jan 3, 2025
10 checks passed
@thomashampson thomashampson deleted the correct_typo_pearl_trans_mode_ws_name branch January 3, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction ISIS: Diffraction Issue and pull requests relating to Diffraction at ISIS Powder Issues and pull requests related to powder diffraction
Projects
Status: Merged
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants