Improve test coverage for PolarizationCorrectionsHelpers methods #38602
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yusufjimoh
added
Reflectometry
rbauststfc
reviewed
Jan 20, 2025
Framework/Algorithms/test/PolarizationCorrections/PolarizationCorrectionsHelpersTest.h
Outdated
Show resolved
Hide resolved
Framework/Algorithms/test/PolarizationCorrections/PolarizationCorrectionsHelpersTest.h
Outdated
Show resolved
Hide resolved
Framework/Algorithms/test/PolarizationCorrections/PolarizationCorrectionsHelpersTest.h
Outdated
Show resolved
Hide resolved
…lper methods - added unit tests to splitSpinStateString - added unit tests to test indexOfWorkspaceForSpinState - added unit tests to test workSpaceForSpinState
yusufjimoh
force-pushed
the
37749-improve-test-coverage-for-polarizationcorrectionshelpers-methods
branch
from
fd6a6f8 to
f7cd3ee
Compare
|
I'm afraid I'm not actually seeing any changes on this PR since my last review - were some commits missed out the last time you pushed to this PR? |
|
I have updated the PR now @rbauststfc |
rbauststfc
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Thanks @yusufjimoh, I can see the changes now. All PR comments have been addressed, the new tests provide very comprehensive test coverage and are well-written for maintainability. This looks good to be merged in 👍
SilkeSchomann
deleted the
37749-improve-test-coverage-for-polarizationcorrectionshelpers-methods
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Fixes #37749
To test:
This does not require release notes because it involves updating the unit tests