Skip to content

Conversation

andy-bridger
Copy link
Collaborator

Description of work

Added System Test for focussing of Polaris and GEM, checking that when multiple ws are passed they are dealt with correctly by input_mode = "Individual"/"Summed"

Additionally reformatted code to avoid repetition

Summary of work

Tests now exist which take run_number="xxxxx,yyyyy" rather than previously where all tests only ever operated on a single run workspace.

The tests simply check for the correct output workspaces i.e. for "Individual" : xxxxx.gsas, xxxxx.nxs, yyyyy.gsas, and yyyyy.nxs should all be produced. For "Summed" only xxxxx,yyyyy.gsas and xxxxx,yyyyy.nxs should be produced.

Fixes #36018.

Further detail of work

Refactoring of code chosen to do Multiple class inheritance but leave the Base Class without comprehensive implementation. Bogging it down with abstractmethod decorators for the not yet instantiated assert methods that need to be inherited from the Testing Class was deemed to be unnecessary for code that is not user-facing.

To test:

Run ISIS_PowderPolarisTest.py and ISIS_PowderGemTest.py

This does not require release notes because no change to any user-facing code


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@andy-bridger andy-bridger added this to the Release 6.13 milestone Jan 23, 2025
@andy-bridger andy-bridger marked this pull request as ready for review January 23, 2025 16:49
@sf1919
Copy link
Contributor

sf1919 commented Jan 24, 2025

Please can you change the branch to main? Only v6.12 milestone bug fixes should be on release-next.

@andy-bridger
Copy link
Collaborator Author

Whoops, I actually had a bit of a faff moving this branch from main to release-next, but fortunately I have the original branch based off main. If you are happy I will just close this PR and reopen the other branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants