Change LegacyNexusDescriptor to use LegacyNexusFile #38824
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
added
the
Maintenance
peterfpeterson
force-pushed
the
38332_legacy_descriptor
branch
from
765f2d6 to
beb759b
Compare
peterfpeterson
force-pushed
the
38332_legacy_descriptor
branch
2 times, most recently
from
ca3871f to
f0e309f
Compare
|
We need to get #38845 in first in case it causes conflicts with this one. |
peterfpeterson
force-pushed
the
38332_legacy_descriptor
branch
from
bf2c46a to
c939520
Compare
peterfpeterson
added
the
Technical Debt
peterfpeterson
force-pushed
the
38332_legacy_descriptor
branch
from
c939520 to
68b3ec7
Compare
rboston628
reviewed
Feb 19, 2025
rboston628
approved these changes
Feb 19, 2025
peterfpeterson
added a commit
to peterfpeterson/mantid
that referenced
this pull request
Feb 19, 2025
This is a squashed version of mantidproject#38824 Disambiguate which NeXus::File is actually being used Rename NexusDescriptor to LegacyNexusDescriptor Add LegacyNexus
This was referenced Feb 19, 2025
rboston628
added
the
Nexus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
NexusDescriptortoLegacyNexusDescriptor, modify it to use the LegacyNexus functions, and update the muon loading algorithms to use it.This pushes more of the code used only by muons out of the way of the upcoming NeXus API rewrite.
Refs #38332
To test:
This is a refactor with no change in functionality. The existing tests should be enough and no release notes are required.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.