-
Notifications
You must be signed in to change notification settings - Fork 128
Create LegacyNexusClasses #38825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create LegacyNexusClasses #38825
Conversation
0ca2718
to
45b7421
Compare
Again I'd like for us to get #38845 in first before this one. |
45b7421
to
d8f4410
Compare
d8f4410
to
f29b58d
Compare
👋 Hi, @rosswhitfield, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
8b73273
to
fd08894
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes should move the muons code to use the LegacyNexus package. The only changes in the muon loaders is to switch dependencies and namespaces.
Description of work
This includes the changes from #38824 and should be reviewed after that is merged.
This creates a copy of
NexusClasses
calledLegacyNexusClasses
that usesLegacyNexus
instead ofNexusCpp
.This PR also switched
LoadMuonNexus1
,LoadMuonNexus2
,LoadMuonNexus3
andMuonNexusReader
fromNexusClasses
toLegacyNexusClasses
/NexusCpp
toLegacyNexus
.Summary of work
Refs #38332
Further detail of work
To test:
This is a refactor with no change in functionality. The existing tests should be enough and no release notes are required.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.