Skip to content

Conversation

rosswhitfield
Copy link
Member

@rosswhitfield rosswhitfield commented Feb 12, 2025

Description of work

This includes the changes from #38824 and should be reviewed after that is merged.

This creates a copy of NexusClasses called LegacyNexusClasses that uses LegacyNexus instead of NexusCpp.

This PR also switched LoadMuonNexus1, LoadMuonNexus2, LoadMuonNexus3 and MuonNexusReader from NexusClasses to LegacyNexusClasses/NexusCpp to LegacyNexus.

  • Build Status windows system tests

Summary of work

Refs #38332

Further detail of work

To test:

This is a refactor with no change in functionality. The existing tests should be enough and no release notes are required.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@rosswhitfield rosswhitfield force-pushed the LegacyNexusClasses branch 6 times, most recently from 0ca2718 to 45b7421 Compare February 17, 2025 05:07
@sf1919
Copy link
Contributor

sf1919 commented Feb 17, 2025

Again I'd like for us to get #38845 in first before this one.

@peterfpeterson peterfpeterson added the Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly label Feb 17, 2025
@rosswhitfield rosswhitfield marked this pull request as ready for review February 19, 2025 05:19
@sf1919 sf1919 added this to the Release 6.13 milestone Feb 19, 2025
@github-actions github-actions bot added the Has Conflicts Used by the bot to label pull requests that have conflicts label Feb 19, 2025
Copy link

👋 Hi, @rosswhitfield,

Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

@peterfpeterson peterfpeterson removed the Has Conflicts Used by the bot to label pull requests that have conflicts label Feb 19, 2025
Copy link
Contributor

@rboston628 rboston628 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes should move the muons code to use the LegacyNexus package. The only changes in the muon loaders is to switch dependencies and namespaces.

@AndreiSavici AndreiSavici merged commit 89ca9f3 into mantidproject:main Feb 20, 2025
10 checks passed
@rosswhitfield rosswhitfield deleted the LegacyNexusClasses branch February 20, 2025 21:04
@rboston628 rboston628 added the Nexus Pull requests that are part of Nexus Refactor in issue #38332 label Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nexus Pull requests that are part of Nexus Refactor in issue #38332 Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants