Get LoadMuonNexus3 compiling in main
#38897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a squashed version of mantidproject#38824 Disambiguate which NeXus::File is actually being used Rename NexusDescriptor to LegacyNexusDescriptor Add LegacyNexus
peterfpeterson
force-pushed
the
38332_legacy_descriptor_loadmuon
branch
from
765938b to
9dc7fa9
Compare
peterfpeterson
added
High Priority
peterfpeterson
changed the title
main
MialLewis
approved these changes
Feb 19, 2025
There was a problem hiding this comment.
First two commits are related to other PRs already reviewed and merged into main (hangovers from a different base branch).
The third commit moves Framework/Muon/inc/MantidMuon/LoadMuonNexus3.h over to use the newly named LegacyNexusDescriptor.
All compiles locally and is working.
rboston628
added
the
Nexus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once #38824 and #38845 were merged into
mainmantid ended up not compiling with what was already merged intomaindue to PRs hanging out too long waiting for review.This was started from
ornl-nextand pulls some other things in frommain. Only the third commit matters.Refs #38332
Further detail of work
To test:
The code should compile again.
This does not require release notes because it fixes an error that was introduced the same day this PR was created.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.