-
Notifications
You must be signed in to change notification settings - Fork 128
Restore Windows PowderReduceP2DTest #39045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why it works now either, but turning it back on works for me.
A third build caused a failure. Seeing what a fourth will do |
Fourth passes. And now starting a fifth... |
5th passed |
Is there a link to the build where this test passed on Windows? |
@thomashampson Here's the most recent: https://builds.mantidproject.org/job/pull_requests-conda-windows/9860/ |
The system tests aren't run on Windows in PRs. |
facepalm We took the passing to mean it was ok. Was waiting on a local windows build to manually run the test as final confirmation, which evidently was needed. |
Reverting in #39068 |
This reverts commit 1336597.
Description of work
PowderReduceP2DTest
was previously disabled due to it throwing an error on windows builds. Since then, it now functions as expected. This PR simply re-enables the test.Summary of work
The test was re-enabled, removing the
skipTests
mark.EWM 7050: [mantid] Fix PowderReduceP2DTest to run on Windows and OSX.
Related to: #37720
Sibling: #39051
Further detail of work
A build was triggered and found to be working. A second build confirmed this. A third failed. 4th passed. 5th passed.
4/5 build attempts have passed - considering this test to be functional
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.