Skip to content

Conversation

ktactac-ornl
Copy link
Contributor

@ktactac-ornl ktactac-ornl commented Mar 12, 2025

Description of work

PowderReduceP2DTest was previously disabled due to it throwing an error on windows builds. Since then, it now functions as expected. This PR simply re-enables the test.

Summary of work

The test was re-enabled, removing the skipTests mark.

EWM 7050: [mantid] Fix PowderReduceP2DTest to run on Windows and OSX.
Related to: #37720
Sibling: #39051

Further detail of work

A build was triggered and found to be working. A second build confirmed this. A third failed. 4th passed. 5th passed.
4/5 build attempts have passed - considering this test to be functional

To test:


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@sf1919 sf1919 added this to the Release 6.13 milestone Mar 12, 2025
@ktactac-ornl ktactac-ornl marked this pull request as draft March 12, 2025 13:32
@ktactac-ornl ktactac-ornl changed the title Ewm7050 powder reduce p2 d test restore Restore PowderReduceP2DTest Mar 13, 2025
@ktactac-ornl ktactac-ornl marked this pull request as ready for review March 13, 2025 16:47
@ktactac-ornl ktactac-ornl self-assigned this Mar 13, 2025
@ktactac-ornl ktactac-ornl added Powder Issues and pull requests related to powder diffraction Windows Only Only on Windows ORNL Team Issues and pull requests managed by the ORNL development team labels Mar 13, 2025
@ktactac-ornl ktactac-ornl changed the title Restore PowderReduceP2DTest Restore Windows PowderReduceP2DTest: Previously caused build errors, now working Mar 13, 2025
@peterfpeterson peterfpeterson changed the title Restore Windows PowderReduceP2DTest: Previously caused build errors, now working Restore Windows PowderReduceP2DTest Mar 13, 2025
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why it works now either, but turning it back on works for me.

@ktactac-ornl
Copy link
Contributor Author

A third build caused a failure. Seeing what a fourth will do

@ktactac-ornl
Copy link
Contributor Author

Fourth passes. And now starting a fifth...

@ktactac-ornl
Copy link
Contributor Author

5th passed

@sf1919 sf1919 merged commit 1336597 into main Mar 14, 2025
11 checks passed
@sf1919 sf1919 self-assigned this Mar 14, 2025
@thomashampson
Copy link
Contributor

Is there a link to the build where this test passed on Windows?

@ktactac-ornl ktactac-ornl deleted the ewm7050-PowderReduceP2DTest-restore branch March 14, 2025 15:56
@ktactac-ornl
Copy link
Contributor Author

ktactac-ornl commented Mar 14, 2025

Is there a link to the build where this test passed on Windows?

@thomashampson Here's the most recent: https://builds.mantidproject.org/job/pull_requests-conda-windows/9860/

@thomashampson
Copy link
Contributor

thomashampson commented Mar 14, 2025

Is there a link to the build where this test passed on Windows?

Here's the most recent: https://builds.mantidproject.org/job/pull_requests-conda-windows/9860/

The system tests aren't run on Windows in PRs.

@ktactac-ornl
Copy link
Contributor Author

ktactac-ornl commented Mar 14, 2025

Is there a link to the build where this test passed on Windows?

Here's the most recent: https://builds.mantidproject.org/job/pull_requests-conda-windows/9860/

The system tests aren't run on Windows in PRs.

facepalm We took the passing to mean it was ok. Was waiting on a local windows build to manually run the test as final confirmation, which evidently was needed.

@ktactac-ornl
Copy link
Contributor Author

ktactac-ornl commented Mar 14, 2025

Reverting in #39068

ktactac-ornl added a commit that referenced this pull request Mar 14, 2025
peterfpeterson pushed a commit that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ORNL Team Issues and pull requests managed by the ORNL development team Powder Issues and pull requests related to powder diffraction Windows Only Only on Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants