Skip to content

39013 highlight bool keywords in script editor #39073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 31, 2025
Merged

39013 highlight bool keywords in script editor #39073

merged 5 commits into from
Mar 31, 2025

Conversation

yusufjimoh
Copy link
Contributor

@yusufjimoh yusufjimoh commented Mar 17, 2025 •
edited
Loading

Description of work

Add support for syntax highlighting of Bool Keywords in mantid python script editor

Fixes #39013

To test:

  • open the Mantid python code editor.
  • enter True or False
  • verify that the keywords are highlighted in blue

@yusufjimoh yusufjimoh linked an issue Mar 17, 2025 that may be closed by this pull request
highlight bool keywords in script editor #39013
Closed
@yusufjimoh yusufjimoh marked this pull request as ready for review March 17, 2025 17:08
@yusufjimoh yusufjimoh added this to the Release 6.13 milestone Mar 17, 2025
@yusufjimoh yusufjimoh added the ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions label Mar 17, 2025
@yusufjimoh yusufjimoh added the GUI Issues and pull requests specific to the Mantid Workbench GUI. label Mar 17, 2025
@yusufjimoh yusufjimoh moved this to Awaiting Approval in ISIS Core Mar 17, 2025
jhaigh0
jhaigh0 requested changes Mar 27, 2025
View reviewed changes
@yusufjimoh yusufjimoh requested a review from jhaigh0 March 28, 2025 16:36
jhaigh0
jhaigh0 approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes, works as expected

@github-project-automation github-project-automation bot moved this from Awaiting Approval to Awaiting Merge in ISIS Core Mar 31, 2025
@SilkeSchomann SilkeSchomann self-assigned this Mar 31, 2025
@SilkeSchomann SilkeSchomann merged commit 3a7960e into main Mar 31, 2025
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 39013-highlight-bool-keywords-in-script-editor branch March 31, 2025 15:25
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in ISIS Core Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhaigh0 jhaigh0 jhaigh0 approved these changes

Assignees

@SilkeSchomann SilkeSchomann

@GuiMacielPereira GuiMacielPereira

Labels
GUI Issues and pull requests specific to the Mantid Workbench GUI. ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions
Projects
ISIS Core
Status: Done
Milestone
Release 6.13
Development

Successfully merging this pull request may close these issues.

highlight bool keywords in script editor
4 participants
@yusufjimoh @jhaigh0 @SilkeSchomann @GuiMacielPereira