Skip to content

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Mar 17, 2025

@sf1919 sf1919 added the Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects. label Mar 18, 2025
@sf1919 sf1919 added this to the Release 6.13 milestone Mar 18, 2025
@RichardWaiteSTFC RichardWaiteSTFC self-assigned this Mar 19, 2025
updates:
- [github.com/pre-commit/mirrors-clang-format: v19.1.7 → v20.1.0](pre-commit/mirrors-clang-format@v19.1.7...v20.1.0)
- [github.com/astral-sh/ruff-pre-commit: v0.9.10 → v0.11.2](astral-sh/ruff-pre-commit@v0.9.10...v0.11.2)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 3240fac to c571815 Compare March 24, 2025 19:53
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the formatting look a bit odd?

Comment on lines +35 to +36
.def(
"getExperimentInfo",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did it add a new line here?

.def("insert", insert_set, (arg("self"), arg("set")))
.def("extend", insert_set, (arg("self"), arg("set")))
.def("erase", (std::size_t(w_t::*)(e_t const &))&w_t::erase, (arg("self"), arg("index")))
.def("erase", (std::size_t (w_t::*)(e_t const &))&w_t::erase, (arg("self"), arg("index")))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we happy with the spaces it's putting for these casts?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems odd

@thomashampson thomashampson force-pushed the pre-commit-ci-update-config branch from 7c31800 to 4d18e98 Compare March 25, 2025 17:19
Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't mind the spaces it's put in, they're consistent at least.

@thomashampson thomashampson merged commit 1d5f6f1 into main Mar 26, 2025
10 checks passed
@thomashampson thomashampson deleted the pre-commit-ci-update-config branch March 26, 2025 16:17
peterfpeterson pushed a commit to peterfpeterson/mantid that referenced this pull request Apr 1, 2025
This is a variant of mantidproject#39076

updates:
- [github.com/pre-commit/mirrors-clang-format: v19.1.7 → v20.1.0](pre-commit/mirrors-clang-format@v19.1.7...v20.1.0)
- [github.com/astral-sh/ruff-pre-commit: v0.9.10 → v0.11.2](astral-sh/ruff-pre-commit@v0.9.10...v0.11.2)

remove unnecessary brackets

Update cppcheck suppression line number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Extra Attention Testers and Gate keepers should pay extra attention as this affects core aspects.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants