Skip to content

Conversation

SilkeSchomann
Copy link
Contributor

Description of work

An image added for the release notes ended up in the top level image folder instead of the docs image folder.

There is no associated issue.

To test:

Check that the documentation builds without problems. Verify that the image on the algorithm page for CreateMonteCarloWorkspace and the index page for the release notes for 6.12 is rendered correctly.

This does not require release notes because it is not a user facing change.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added Documentation Issues and pull requests related to documentation Maintenance Unassigned issues to be addressed in the next maintenance period. labels Mar 18, 2025
@SilkeSchomann SilkeSchomann added this to the Release 6.13 milestone Mar 18, 2025
@github-project-automation github-project-automation bot moved this to Unassigned in DEVS Mar 18, 2025
@SilkeSchomann SilkeSchomann marked this pull request as ready for review March 18, 2025 12:17
@SilkeSchomann SilkeSchomann moved this from Unassigned to In review in DEVS Mar 19, 2025
@github-project-automation github-project-automation bot moved this from In review to Approved in DEVS Mar 19, 2025
@sf1919 sf1919 self-assigned this Mar 20, 2025
@sf1919 sf1919 merged commit c7c1dc3 into main Mar 20, 2025
10 checks passed
@sf1919 sf1919 deleted the move_image_for_release_notes branch March 20, 2025 09:50
@github-project-automation github-project-automation bot moved this from Approved to Merged in DEVS Mar 20, 2025
peterfpeterson pushed a commit to peterfpeterson/mantid that referenced this pull request Jun 19, 2025
…9077)

* Moved image for release notes into doc image folder

* Modified image paths

* Removed image in old location
peterfpeterson added a commit that referenced this pull request Jun 19, 2025
This pulls in a variety of build configuration and release note changes
from `main` into `ornl-next`
* current configuration of `pre-commit-config.yaml`
* all release notes in their current state from v6.13 and before
(inclusive)
* fix to sourcelink directive bundled into #39008
* #39363
* #39324
* #39307
* #39049
* #39077

---------

Co-authored-by: MialLewis <95620982+MialLewis@users.noreply.github.com>
Co-authored-by: Adri Diaz <146007827+adriazalvarez@users.noreply.github.com>
Co-authored-by: Gui Maciel Pereira <80104863+GuiMacielPereira@users.noreply.github.com>
Co-authored-by: Glass <glass.ships@outlook.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Silke Schomann <74243814+SilkeSchomann@users.noreply.github.com>
Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants