unpin mkl in dependencies #39114
Merged
unpin mkl in dependencies #39114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
thomashampson
requested changes
Mar 27, 2025
jhaigh0
previously approved these changes
Apr 2, 2025
jhaigh0
approved these changes
Apr 2, 2025
thomashampson
approved these changes
Apr 2, 2025
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Apr 4, 2025
mkl was pinned a while ago to avoid unit test failures. It seems that this is no longer required. --------- Co-authored-by: Tom Hampson <thomas.hampson@stfc.ac.uk>
peterfpeterson
added a commit
that referenced
this pull request
Apr 4, 2025
* Pin Pydantic in mantid recipe (#39136) Pin pydantic in mantid recipe Pydantic was pinned in the developer meta-package to avoid a test failure. We need to pin it here too to make sure we're releasing with the same version that we're testing against. * unpin mkl in dependencies (#39114) mkl was pinned a while ago to avoid unit test failures. It seems that this is no longer required. --------- Co-authored-by: Tom Hampson <thomas.hampson@stfc.ac.uk> --------- Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk> Co-authored-by: yusufjimoh <168747442+yusufjimoh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
mklwas pinned here to avoid unit test failures. The pin is removed and magically the unit tests are working again, so something upstream must have been fixed.Fixes #38301
To test:
Ensure that
mklhas been unpinned everywhere. It is not a primary dependency, so should not be present inside the conda recipes directly.This does not require release notes because it's an unpinning of a secondary dependency
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.