Build and cppcheck fixes - ornl-next #39129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
changed the title
* Cppcheck suppressions set 56 * Remove lines from suppressions and other fixes Py_RETURN_NONE renamed to Py_NONE and return removed (now to be done manually) as not used anywhere else and was confusing cppcheck with missing return. Had to make lambda function wrapper if wanted to return const pointer in AlgorithmProperty.cpp Co-authored-by: Mohamed Almaki <MohamedAlmaki@users.noreply.github.com> * Not use macro to return * Replace std::function pointer with a C style function pointer * Update Framework/PythonInterface/mantid/api/src/Exports/IPeakFunction.cpp Co-authored-by: Gui Maciel Pereira <80104863+GuiMacielPereira@users.noreply.github.com> * Update Framework/PythonInterface/mantid/api/src/Exports/IFunction1D.cpp Co-authored-by: Gui Maciel Pereira <80104863+GuiMacielPereira@users.noreply.github.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update Framework/PythonInterface/mantid/api/src/Exports/IFunction1D.cpp Co-authored-by: Gui Maciel Pereira <80104863+GuiMacielPereira@users.noreply.github.com> * Update Framework/PythonInterface/mantid/api/src/Exports/IPeakFunction.cpp Co-authored-by: Gui Maciel Pereira <80104863+GuiMacielPereira@users.noreply.github.com> * Revert constParameterCallback suppression fix --------- Co-authored-by: Mohamed Almaki <MohamedAlmaki@users.noreply.github.com> Co-authored-by: Mohammed Almakki <mohammed.almakki@stfc.ac.uk> Co-authored-by: Gui Maciel Pereira <80104863+GuiMacielPereira@users.noreply.github.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…ct#39004) * fix some knownConditionTrueFalse warnings * fix cascading ccpcheck warnings * Review suggestions Co-authored-by: James Clarke <james.clarke@stfc.ac.uk> --------- Co-authored-by: James Clarke <james.clarke@stfc.ac.uk>
updates: - [github.com/pre-commit/mirrors-clang-format: v19.1.7 → v20.1.0](pre-commit/mirrors-clang-format@v19.1.7...v20.1.0) - [github.com/astral-sh/ruff-pre-commit: v0.9.10 → v0.11.2](astral-sh/ruff-pre-commit@v0.9.10...v0.11.2) remove unnecessary brackets Update cppcheck suppression line number
* Delete unnecessary virtual destructors. * Fixes for ImportMDHistoWorkspaceBase The member variable nbins is unused, and was shadowed inside a method. Also made some variables in that method const. * AlgorithmDialog missing const in a few places * Fix some return by reference in FitPropertyBrowser * Fix several passedByValue Cppcheck warnings * Further Cppcheck fixes
peterfpeterson
force-pushed
the
build_fixes
branch
from
c06c652 to
221dc35
Compare
* some stl related cppchecks * additional ccpcheck fixes from line numbers moving * remove fix that I think is causing the test failure * use std optional to avoid uninitialised warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies the following fixes into
ornl-next