ornl-next packaging issue #39211
Merged
ornl-next packaging issue #39211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#38600) * add pystack to workbench and developer environments * Turn on core dumps on linux for the inner workbench process Has to switch from multiprocessing to subprocess in order to do this (needed the preexec option). Through some testing, this should preserve the desired spawn behaviour. A new module 'workbench_process.py' has been created to use with subprocess.run (can't pass it a function) * add module to get the compressed output from pystack on the latest worbench core file * add tests for new run pystack module * add cpp traces to the report sender * base64 encode data to store as a string * show pystack output in the show more details window * add release note * update existing tests * fix pystack test * add support for lz4 compressed core files, such as those on idaaas * only import lz4 if on linux * return Path type as intended * use process id to identify core dump file * move release note to 6.13 * pass missing parameter to errorreporter constructor * only launch with preexec_func when not on windows to avoid crash * add property to user properties default file * Update comment in run_pystack --------- Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk>
peterfpeterson
merged commit f2748d4
into
mantidproject:ornl-next
8 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in a variety of things from
mainintoornl-nextthings that might fix starting the workbench