Fix SNSPowderRedux system tests for alma9 #39231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This has been tested on an alma9 runner and the SNS tests did pass - https://builds.mantidproject.org/job/Core_Team_test_pipeline/225/ The only failing test was |
|
Re-running Linux and systems tests on an alam9 node specifically - https://builds.mantidproject.org/job/pull_requests-conda-linux/11942/ |
thomashampson
approved these changes
May 1, 2025
glass-ships
pushed a commit
that referenced
this pull request
May 1, 2025
When starting to work to migrate from centos7 to alma9 (mantidproject/dockerfiles#111), some tests failed as seen in [build 205](https://builds.mantidproject.org/job/Core_Team_test_pipeline/205/). The failing tests (in case the log disappears) are `SystemTests.SNSPowderRedux.PG3Analysis`, `SystemTests.SNSPowderRedux.PG3StripPeaks`, and `SystemTests.BayesQuasiTest.BayesQuasiTest`. This fixes the SNSPowderRedux tests by updating the reference results after manually inspecting them. There is also a minor change to the test which reduces the runtime of the test by 2-3 seconds.
glass-ships
pushed a commit
that referenced
this pull request
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting to work to migrate from centos7 to alma9 (mantidproject/dockerfiles#111), some tests failed as seen in build 205. The failing tests (in case the log disappears) are
SystemTests.SNSPowderRedux.PG3Analysis,SystemTests.SNSPowderRedux.PG3StripPeaks, andSystemTests.BayesQuasiTest.BayesQuasiTest. This fixes the SNSPowderRedux tests by updating the reference results after manually inspecting them.There is also a minor change to the test which reduces the runtime of the test by 2-3 seconds.
There is no associated issue, but this is related to EWM10130
To test:
Since this is updating system tests, they should pass.
This does not require release notes because it is only updating a system test.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.