Skip to content

Conversation

jhaigh0
Copy link
Contributor

@jhaigh0 jhaigh0 commented Apr 24, 2025

Description of work

A recent change to how workbench launches seem to have broken the linux stand-alone launch.

The problem was that workbench now launches using a a python command, we don't add the stand-alone bin directory to the PATH so when launching it would either use the wrong python or not launch at all.

This pr changes the command to use the specific python binary found within the bin folder.

Further detail of work

To test:

Test stand-alone launchers launch

https://builds.mantidproject.org/job/build_packages_from_branch/1091/


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@jhaigh0 jhaigh0 force-pushed the specify_python_on_launch branch from 00548bf to 682a685 Compare April 25, 2025 10:26
@jhaigh0 jhaigh0 marked this pull request as ready for review April 28, 2025 10:40
@jhaigh0 jhaigh0 added this to the Release 6.13 milestone Apr 28, 2025
@jhaigh0 jhaigh0 added the ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions label Apr 28, 2025
@jclarkeSTFC jclarkeSTFC self-assigned this Apr 28, 2025
@jclarkeSTFC jclarkeSTFC moved this to Awaiting Approval in ISIS Core Apr 28, 2025
@jclarkeSTFC
Copy link
Contributor

Can't get the Windows standalone to start

@jhaigh0
Copy link
Contributor Author

jhaigh0 commented Apr 28, 2025

Can't get the Windows standalone to start

Realised I didn't re-run after switching to sys.executable, sorry about that. Have re-run and updated the link now.

Copy link
Contributor

@jclarkeSTFC jclarkeSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Standalone launches on Linux and Windows with the correct sys.executable path.

@github-project-automation github-project-automation bot moved this from Awaiting Approval to Awaiting Merge in ISIS Core Apr 29, 2025
@thomashampson thomashampson self-assigned this Apr 29, 2025
@thomashampson thomashampson merged commit 1e17ac8 into main Apr 29, 2025
10 checks passed
@thomashampson thomashampson deleted the specify_python_on_launch branch April 29, 2025 08:30
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in ISIS Core Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants