Skip to content

Conversation

dlcaballero16
Copy link
Contributor

Description of work

Summary of work

Made changes to make LoadSpec a file loader, removed file from banned
list since LoadSpec is now a file loader

EWM Item: 10859

To test:

Make sure LoadSpec now behaves like a file loader and that test LoadLotsOfFiles.py passes.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@dlcaballero16 dlcaballero16 marked this pull request as ready for review April 25, 2025 14:35
@sf1919
Copy link
Contributor

sf1919 commented Apr 25, 2025

This needs a milestone and labels please

@dlcaballero16 dlcaballero16 added the ORNL Team Issues and pull requests managed by the ORNL development team label Apr 25, 2025
@dlcaballero16 dlcaballero16 added this to the Release 6.13 milestone Apr 25, 2025
@dlcaballero16 dlcaballero16 added the Framework Issues and pull requests related to components in the Framework label Apr 25, 2025
@sf1919
Copy link
Contributor

sf1919 commented Apr 25, 2025

The doc tests are failing because the New Features folder in Data Handling part of the release notes is new. You need to update the top level release note accordingly to pick up your release note. See https://developer.mantidproject.org/Standards/ReleaseNotesGuide.html#adding-sub-headings for information on how to do that.

Once the doc tests are fixed the packaging tests should pass too.

@dlcaballero16
Copy link
Contributor Author

The doc tests are failing because the New Features folder in Data Handling part of the release notes is new. You need to update the top level release note accordingly to pick up your release note. See https://developer.mantidproject.org/Standards/ReleaseNotesGuide.html#adding-sub-headings for information on how to do that.

Once the doc tests are fixed the packaging tests should pass too.

Ok I just updated the top level, hopefully I did this correctly. Though I noticed there wasn't already a sub heading for both Deprecated and Removed for Data_Handling, so not sure how those builds were passing before

Copy link
Contributor

@backmari backmari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I have verified that the system test LoadLotsOfFiles.py runs and I can also use the generic Load algorithm to load a "spec" file and the correct loader is seen in the history.

@peterfpeterson peterfpeterson merged commit 4f28cd6 into main May 1, 2025
9 checks passed
@peterfpeterson peterfpeterson deleted the ewm10859-register-LoadSpec-as-fileloader branch May 1, 2025 13:24
dlcaballero16 added a commit that referenced this pull request May 2, 2025
Made changes to make LoadSpec a file loader, removed file from banned list since LoadSpec is now a file loader
dlcaballero16 added a commit that referenced this pull request May 2, 2025
Made changes to make LoadSpec a file loader, removed file from banned list since LoadSpec is now a file loader
dlcaballero16 added a commit that referenced this pull request May 2, 2025
Made changes to make LoadSpec a file loader, removed file from banned list since LoadSpec is now a file loader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework ORNL Team Issues and pull requests managed by the ORNL development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants