-
Notifications
You must be signed in to change notification settings - Fork 128
Updated LoadSpec to be a file loader #39243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
list since LoadSpec is now a file loader
This needs a milestone and labels please |
The doc tests are failing because the Once the doc tests are fixed the packaging tests should pass too. |
Ok I just updated the top level, hopefully I did this correctly. Though I noticed there wasn't already a sub heading for both Deprecated and Removed for Data_Handling, so not sure how those builds were passing before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I have verified that the system test LoadLotsOfFiles.py
runs and I can also use the generic Load
algorithm to load a "spec" file and the correct loader is seen in the history.
Made changes to make LoadSpec a file loader, removed file from banned list since LoadSpec is now a file loader
Made changes to make LoadSpec a file loader, removed file from banned list since LoadSpec is now a file loader
Made changes to make LoadSpec a file loader, removed file from banned list since LoadSpec is now a file loader
Description of work
Summary of work
Made changes to make LoadSpec a file loader, removed file from banned
list since LoadSpec is now a file loader
EWM Item: 10859
To test:
Make sure LoadSpec now behaves like a file loader and that test LoadLotsOfFiles.py passes.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.