Skip to content

Conversation

MialLewis
Copy link
Contributor

@MialLewis MialLewis commented Apr 25, 2025

Description of work

Adds a minimum size to the SampleLogsView canvas. This prevents it being set to a negative size when resized, avoiding an error.

Fixes #39247

Further detail of work

To test:

Refer to instructions on issue.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@MialLewis MialLewis marked this pull request as ready for review April 25, 2025 10:39
@MialLewis MialLewis added this to the Release 6.13 milestone Apr 25, 2025
@jhaigh0 jhaigh0 self-assigned this Apr 29, 2025
Copy link
Contributor

@jhaigh0 jhaigh0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change, plot now reaches a minimum size, then snaps hidden.

@SilkeSchomann SilkeSchomann self-assigned this Apr 29, 2025
@SilkeSchomann SilkeSchomann merged commit cc724ec into main Apr 29, 2025
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 39247_fix_crash_on_sample_log_plot_resize branch April 29, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minimizing sample log plot on a workspace with time series logs causes crash
3 participants