Skip to content

Add capability to save multiple workspaces in ascii format #39249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2025
Merged

Add capability to save multiple workspaces in ascii format #39249

merged 3 commits into from
May 13, 2025
+50 −41

Conversation

yusufjimoh
Copy link
Contributor

@yusufjimoh yusufjimoh commented Apr 25, 2025 •
edited
Loading

Description of work

  • Modify code to allow saving of workspaces in ascii format

Fixes #38807

Report to: Anna (Vesuvio instrument scientist)

To test:

  • Add workspaces to Mantid Workbench.
  • Click and select multiple workspaces; the option to save the multiple items as Nexus and ASCII should be available.
  • Save the workspaces
  • Verify that you can successfully save them as both ASCII and Nexus files.

@yusufjimoh yusufjimoh linked an issue Apr 25, 2025 that may be closed by this pull request
Save multiple workspaces into ASCII #38807
Closed
@yusufjimoh yusufjimoh added the ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions label Apr 25, 2025
@yusufjimoh yusufjimoh added this to the Release 6.13 milestone Apr 25, 2025
@yusufjimoh yusufjimoh marked this pull request as ready for review April 25, 2025 13:26
@jhaigh0 jhaigh0 self-assigned this Apr 29, 2025
jhaigh0
jhaigh0 previously approved these changes Apr 29, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this to Awaiting Merge in ISIS Core Apr 29, 2025
@jclarkeSTFC jclarkeSTFC self-assigned this Apr 29, 2025
jclarkeSTFC
jclarkeSTFC previously requested changes Apr 29, 2025
View reviewed changes
Copy link
Contributor

@jclarkeSTFC jclarkeSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine, nice improvement. I spotted one thing that potentially can be removed, but leaving it in wouldn't do any harm as far as I can tell.

@jclarkeSTFC jclarkeSTFC dismissed their stale review May 12, 2025 13:59

Changes made

@jclarkeSTFC jclarkeSTFC enabled auto-merge (squash) May 12, 2025 13:59
@jclarkeSTFC jclarkeSTFC requested a review from jhaigh0 May 12, 2025 13:59
@jclarkeSTFC jclarkeSTFC merged commit 197c403 into main May 13, 2025
10 checks passed
@jclarkeSTFC jclarkeSTFC deleted the 38807-save-multiple-workspaces-into-ascii branch May 13, 2025 10:43
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in ISIS Core May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhaigh0 jhaigh0 jhaigh0 approved these changes

@jclarkeSTFC jclarkeSTFC jclarkeSTFC left review comments

Assignees

@jhaigh0 jhaigh0

@jclarkeSTFC jclarkeSTFC

Labels
ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions
Projects
ISIS Core
Status: Done
Milestone
Release 6.13
Development

Successfully merging this pull request may close these issues.

Save multiple workspaces into ASCII
3 participants
@yusufjimoh @jhaigh0 @jclarkeSTFC