Skip to content

Add capability to save multiple workspaces in ascii format #39249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 13, 2025
Merged

Add capability to save multiple workspaces in ascii format #39249

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a1e1e6
- Add capability to save multiple workspaces in ascii format
yusufjimoh Apr 25, 2025
4dca1f9
add release note
yusufjimoh Apr 25, 2025
108f327
Remove surplus code
jclarkeSTFC May 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/source/release/v6.13.0/Workbench/New_features/38807.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Users can now save multiple selected workspaces as ASCII.
91 changes: 52 additions & 39 deletions qt/widgets/common/src/WorkspacePresenter/WorkspaceTreeWidget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,17 +371,25 @@ void WorkspaceTreeWidget::saveWorkspaceCollection() {

void WorkspaceTreeWidget::handleShowSaveAlgorithm() {
const QAction *sendingAction = dynamic_cast<QAction *>(sender());
if (!sendingAction)
return;

if (sendingAction) {
QString actionName = sendingAction->text();
QString actionName = sendingAction->text();

if (actionName.compare("Nexus") == 0)
m_saveFileType = SaveFileType::Nexus;
else if (actionName.compare("ASCII") == 0)
m_saveFileType = SaveFileType::ASCII;
}
if (actionName.compare("Nexus") == 0)
m_saveFileType = SaveFileType::Nexus;
else if (actionName.compare("ASCII") == 0)
m_saveFileType = SaveFileType::ASCII;

m_presenter->notifyFromView(ViewNotifiable::Flag::SaveSingleWorkspace);
auto selectedNames = getSelectedWorkspaceNames();

if (selectedNames.size() > 1) {
// Save multiple workspaces
saveWorkspaces(selectedNames);
} else if (selectedNames.size() == 1) {
// Save single workspace
m_presenter->notifyFromView(ViewNotifiable::Flag::SaveSingleWorkspace);
}
}

WorkspaceTreeWidget::SaveFileType WorkspaceTreeWidget::getSaveFileType() const { return m_saveFileType; }
Expand Down Expand Up @@ -413,22 +421,39 @@ void WorkspaceTreeWidget::saveWorkspaces(const StringList &wsNames) {

m_saveFolderDialog->setWindowTitle("Select save folder");
m_saveFolderDialog->setLabelText(QFileDialog::Accept, "Select");

auto res = m_saveFolderDialog->exec();
if (res != QFileDialog::Accepted)
return;

auto folder = m_saveFolderDialog->selectedFiles()[0].toStdString();

IAlgorithm_sptr saveAlg = AlgorithmManager::Instance().create("SaveNexus");
std::string algorithmName;
std::string fileExtension;

switch (m_saveFileType) {
case SaveFileType::ASCII:
algorithmName = "SaveAscii";
fileExtension = ".dat";
break;
case SaveFileType::Nexus:
default:
algorithmName = "SaveNexus";
fileExtension = ".nxs";
break;
}

IAlgorithm_sptr saveAlg = AlgorithmManager::Instance().create(algorithmName);
saveAlg->initialize();

if (res == QFileDialog::Accepted) {
for (auto &wsName : wsNames) {
std::string filename = folder + "/" + wsName + ".nxs";
try {
saveAlg->setProperty("InputWorkspace", wsName);
saveAlg->setProperty("Filename", filename);
saveAlg->execute();
} catch (std::exception &ex) {
docklog.error() << "Error saving workspace " << wsName << ": " << ex.what() << '\n';
}
for (auto &wsName : wsNames) {
std::string filename = folder + "/" + wsName + fileExtension;
try {
saveAlg->setProperty("InputWorkspace", wsName);
saveAlg->setProperty("Filename", filename);
saveAlg->execute();
} catch (std::exception &ex) {
docklog.error() << "Error saving workspace " << wsName << ": " << ex.what() << '\n';
}
}
}
Expand Down Expand Up @@ -1063,30 +1088,18 @@ void WorkspaceTreeWidget::workspaceSelected() {
if (selectedNames.empty())
return;

// If there are multiple workspaces selected group and save as Nexus
if (selectedNames.size() > 1) {
connect(m_saveButton, SIGNAL(clicked()), this, SLOT(saveWorkspaceCollection()));
// Remove all existing save algorithms from list
m_saveMenu->clear();

// Don't display as a group
m_saveButton->setMenu(nullptr);
} else {
// Don't run the save group function when clicked
disconnect(m_saveButton, SIGNAL(clicked()), this, SLOT(saveWorkspaceCollection()));

// Remove all existing save algorithms from list
m_saveMenu->clear();
addSaveMenuOption("SaveNexus", "Nexus");
addSaveMenuOption("SaveAscii", "ASCII");

// Add some save algorithms
addSaveMenuOption("SaveNexus", "Nexus");
addSaveMenuOption("SaveAscii", "ASCII");
m_saveButton->setMenu(m_saveMenu);

// Set the button to show the menu
m_saveButton->setMenu(m_saveMenu);
if (selectedNames.size() == 1) {
auto wsName = selectedNames[0];
m_mantidDisplayModel->enableSaveNexus(QString::fromStdString(wsName));
}

auto wsName = selectedNames[0];
// TODO: Wire signal correctly in applicationwindow
m_mantidDisplayModel->enableSaveNexus(QString::fromStdString(wsName));
}

/// Handles group button clicks
Expand Down