Improve NeXusException information #39250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfpeterson
added
the
Technical Debt
peterfpeterson
changed the title
rboston628
approved these changes
Apr 25, 2025
glass-ships
pushed a commit
that referenced
this pull request
Apr 28, 2025
* Add more template instantiations * Add more template instantiations * Remove unnecessary and confusing function * Change closeGroup to closeData * Quiet compiler warning * Call openPath with absolute path * Change from char array to string * Add function name as a variable in NexusException
rboston628
added
the
Nexus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the overall campaign to rewrite nexus usage with H5File, this has 3 features:
char *tostd::stringH5Util::getDataSpace(const std::vector<NumT> &data)Refs #38332 and EWM8451
To test:
This is a refactor so a code review is most appropriate.
This does not require release notes because it will be included in the nexus refactor release note that is coming soon.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.