Skip to content

Fix performance issue with groupDetectors2 #39255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

Fix performance issue with groupDetectors2 #39255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions Framework/DataHandling/src/GroupDetectors2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1010,6 +1010,13 @@ size_t GroupDetectors2::formGroupsEvent(const DataObjects::EventWorkspace_const_
// Start fresh with no detector IDs
outEL.clearDetectorIDs();

// Reserve space for the event list
std::size_t totalEvents = 0;
for (auto i : it->second) {
totalEvents += inputWS->getSpectrum(i).getNumberEvents();
}
outEL.reserve(totalEvents);

// the Y values and errors from spectra being grouped are combined in the
// output spectrum
// Keep track of number of detectors required for masking
Expand Down