Remove nested boost::optionals in ISISReflectometry - ornl-next #39260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r plot on workspace load (mantidproject#38838) * Add region selectors to slice viewer plot when have matching settings When loading a workspace or updating the angle on the preview tab, display region selectors on the slice viewer plot for any matching experiment settings from the look-up table. * Remove method that is no longer used * Add release notes for issue 36573 * Update preview tab manual testing instructions
) * Add validatorT typedef as a std::pair of boost::optional<T> and bool to avoid the need for nested boost:optional * Refactor variadic template functions to validate all table fields are properly initialized, and use simpler fold syntax to check validity of all rows * Change boost optional in common classes * - Changed boost to std optional in batch classes - Change boost::optional<T&> to std::optional<std::reference_wrapper<T>> * - Changed boost to std optional in decoder/encoder * - Changed boost to std optional in experiment and preview classes * - Changed boost to std optional in Runs and RunsTable * - Changed boost to std optional in Reduction * - Make tests compatible with changes to std::optional in IsisReflectometry * - Change more boost optional in ISIS Reflectometry * - Remove unused allinitialized file * Fix a bunch of cppcheck suppresions * Move TaggetOptional out of validation result * remove unnecesary include * Make sure boost::optional contains values before initializing clipboard * Move TaggedOptional into ParseReflectometryStrings * Fix broken scale factor test * Remove unnecesary creation of optionals for the row objects and rename variables to more appropriate names as nested boost optional is no longer used * Add extra check for std::nullopt in parse scale factor test
peterfpeterson
merged commit 35ae4c8
into
mantidproject:ornl-next
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls the following changes from
mainintoornl-next