Skip to content

Conversation

Pasarus
Copy link
Contributor

@Pasarus Pasarus commented May 1, 2025

Description of work

Mantid can fail to compile on slightly more up-to-date operating systems (OS), this will fix this.

Summary of work

Added std:: in front of some isnan calls in 2 files.

Purpose of work

Work was completed because I was trying to compile mantid, and I've posted this PR so others won't need to do the same.

There is no associated issue.

Further detail of work

Added std:: in front of some isnan calls in 2 files.

To test:

There are no instructions to test, as testing is compiling, and it should have compiled in the Jenkins workflows.

This does not require release notes because it is not user-facing and is just about compiling Mantid on a more up-to-date OS


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@thomashampson thomashampson self-assigned this May 1, 2025
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes.

@SilkeSchomann SilkeSchomann self-assigned this May 1, 2025
@SilkeSchomann
Copy link
Contributor

@Pasarus Please add the 6.13 milestone.

@Pasarus
Copy link
Contributor Author

Pasarus commented May 1, 2025

I cannot

@SilkeSchomann SilkeSchomann added this to the Release 6.13 milestone May 1, 2025
@SilkeSchomann
Copy link
Contributor

I cannot
Ah, ok. Done.

@SilkeSchomann SilkeSchomann merged commit bad4786 into mantidproject:main May 1, 2025
10 checks passed
@Pasarus Pasarus deleted the use_stdisnan branch May 1, 2025 13:12
@thomashampson thomashampson added the Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly label May 1, 2025
peterfpeterson pushed a commit that referenced this pull request May 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Marks a piece of work to address technical debt introduced to solve a problem quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants