Updates to OptionalBool (#39241) #39269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is running on the new Linux nodes so nothing needs to be re-run as part of the switchover |
* Update usage of OptionalBool in Divide algorithm * add release note * add include for MandatoryValidator * validate as part of assignment and construction, add helper to PropertyHelper * tests work but compiling gives warnings * suppress warnings with [[maybe_unused]] * remove comments and print statements * modify test template * use setProperty instead of assignment * add int constructor/assignment and update test * make strings case insensitive, add optionalbooltests * only import <algorithm>, not bits/c++.h * Update Framework/Kernel/inc/MantidKernel/PropertyHelper.h Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
glass-ships
force-pushed
the
update-optional-bool
branch
from
751812d to
822cb2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sister PR to #39241