Update miniforge #39272
Merged
Update miniforge #39272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomashampson
added
the
ISIS: Core
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @thomashampson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
thomashampson
force-pushed
the
update_miniforge
branch
from
0c05ce3 to
e083bcb
Compare
github-actions
bot
removed
the
Has Conflicts
github-actions
bot
added
the
Has Conflicts
|
👋 Hi, @thomashampson, Conflicts have been detected against the base branch. Please rebase your branch against the base branch. |
Mambaforge no longer exists, so rename all instances.
thomashampson
force-pushed
the
update_miniforge
branch
from
e083bcb to
5c86082
Compare
github-actions
bot
removed
the
Has Conflicts
|
OSX rebuild is waiting in the queue |
MohamedAlmaki
approved these changes
Jul 31, 2025
peterfpeterson
pushed a commit
to peterfpeterson/mantid
that referenced
this pull request
Aug 4, 2025
Mambaforge was replaced by miniforge ([reference](https://github.com/conda-forge/miniforge?tab=readme-ov-file#whats-the-difference-between-mambaforge-and-miniforge)). Here we update to a newer version, and rename any instances for consistency. Co-authored-by: James Clarke <james.clarke@stfc.ac.uk> Co-authored-by: sf1919 <sarah.foxley@stfc.ac.uk>
peterfpeterson
added a commit
that referenced
this pull request
Aug 4, 2025
This gets the following into `ornl-next` * #39272 * #39744 --------- Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk> Co-authored-by: James Clarke <james.clarke@stfc.ac.uk> Co-authored-by: sf1919 <sarah.foxley@stfc.ac.uk> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Mambaforge was replaced by miniforge (reference). Here we update to a newer version, and rename any instances for consistency.
Fixes #38848
To test:
Ensure that this test package build passes on all OS:
This does not require release notes because it's an internal update to build tools.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeeperswill take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.