Changes to algorithms cmake #39290
Merged
Changes to algorithms cmake #39290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* setup alg * add initial tests * add further tests * add alg docs * add release note * rename alg doc * fix crystal structure reference * review updates * add option for declaring alternate scattering volume pos * add reflection check
…ade (mantidproject#38898) * Add v6 POLDIAutoCorrelation algorithm and util functions * Speed up calculation by replacing np.mod * Add input validation to workspace * Convert output to Q to match v5 of POLDIAutoCorrelation * Use v5 of PoldiAutoCorrelation in systems test and workflow algorithm * Add function to simulate 2d workspace * Fix out by 1/2 time bin bug in auto-corr Needed to correct for fact first bin center is at bin_width / 2 not 0 * Convert to point data if converting to d-spacing prior to interp Also remove use of deprecated scipy.interpolate.interp1d * Get max time bin from cycle period (based on chopper speed) * Make t0 parameter correspond to fraction of cycle time So same parameter can be used for any chopper speed * Add new algorithm doc and test data * Add unit test * Fix doc test indent typo on figure caption * Add comment on d-spacing range calculated * Fix doc tests using old POLDI data (prior to upgrade) This requires calling PoldiAutoCorrelation with Version=5 * Fix AlgorithmWorkspaceGroupValidateInputsTest ws = self.getProperty("InputWorkspace").value returns None is passed a group workspace. Could have moved these checks into exec but better to tell user in algorithm GUI than in runtime error. If user does pass a group workspace of invalid workspaces Mantid won't crash the algorithm will just error because it can't find the right component. * Add release notes And update copyright date in headers * Fix doc strings, typos and add comments after review * Use if TYPE_CHECKING for compatibility with future static analysis See discussion on mantidproject#38773 https://github.com/mantidproject/mantid/pull/38773/files#r1979127157 * Use setAlwaysStoreInADS(False) in algorithm manager * Add more info about the correlation summation/average
<!--pre-commit.ci start--> updates: - [github.com/pre-commit/mirrors-clang-format: v20.1.0 → v20.1.3](pre-commit/mirrors-clang-format@v20.1.0...v20.1.3) - [github.com/astral-sh/ruff-pre-commit: v0.11.7 → v0.11.8](astral-sh/ruff-pre-commit@v0.11.7...v0.11.8) <!--pre-commit.ci end--> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
…idproject#38960) * optional add position flag for detector table * updated new parameter declaration * added detector position to exception handling * updated the docstring of createDetectorTableWorkspace * added release note * disable include position option for peaks ws * added test coverage for the no detector exceptions * add semicolons to endo of assert statements * check table population isn't just null values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus updating pre-commit configuration
IncludeDetectorPositiontoCreateDetectorTable#38960