Skip to content

Conversation

KyleQianliMa
Copy link
Contributor

Description of work

Copy of PR 39826 to ORNL-next

Summary of work

Fixes #xxxx.

Further detail of work

To test:


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@KyleQianliMa KyleQianliMa added the ornl-next A copy of a branch into the ornl-next fork label May 7, 2025
@KyleQianliMa KyleQianliMa marked this pull request as ready for review May 7, 2025 15:18
@KyleQianliMa KyleQianliMa enabled auto-merge (squash) May 7, 2025 15:22
@KyleQianliMa KyleQianliMa added this to the Release 6.13 milestone May 7, 2025
@KyleQianliMa KyleQianliMa merged commit 9c95392 into ornl-next May 7, 2025
9 of 11 checks passed
@KyleQianliMa KyleQianliMa deleted the croshair_3d branch May 7, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ornl-next A copy of a branch into the ornl-next fork
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant