Skip to content

Conversation

dlcaballero16
Copy link
Contributor

Description of work

Summary of work

IntegratePeaksCWSD is now marked as deprecated.

EWM item 10036

To test:

Make sure correct log messages show up when trying to use the deprecated algorithm.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@dlcaballero16 dlcaballero16 marked this pull request as ready for review May 8, 2025 13:04
@dlcaballero16 dlcaballero16 added Framework Issues and pull requests related to components in the Framework ORNL Team Issues and pull requests managed by the ORNL development team labels May 8, 2025
@dlcaballero16 dlcaballero16 added this to the Release 6.13 milestone May 8, 2025
Copy link
Contributor

@zjmorgan zjmorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@peterfpeterson peterfpeterson merged commit 4d7c190 into main May 9, 2025
10 checks passed
@peterfpeterson peterfpeterson deleted the ewm10036-deprecate-IntegratePeaksCWSD branch May 9, 2025 16:57
dlcaballero16 added a commit that referenced this pull request May 9, 2025
dlcaballero16 added a commit that referenced this pull request May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework ORNL Team Issues and pull requests managed by the ORNL development team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants