Skip to content

Conversation

SilkeSchomann
Copy link
Contributor

Description of work

This PR adds the release notes for MSlice for release 6.13. of Mantid.

There is no associated issue.

To test:

Read the release notes and check grammar as well as spelling.

This does not require release notes because it is the release notes :-;


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added the ISIS: Excitations/Vesuvio Issue and pull requests relating to Excitiations/Vesuvio at ISIS label Jun 9, 2025
@github-project-automation github-project-automation bot moved this to Unassigned in DEVS Jun 9, 2025
@SilkeSchomann SilkeSchomann marked this pull request as ready for review June 9, 2025 10:00
@SilkeSchomann SilkeSchomann added this to the Release 6.13 milestone Jun 9, 2025
@SilkeSchomann SilkeSchomann moved this to Ready for Review in v6.13 Release Jun 9, 2025
@SilkeSchomann SilkeSchomann moved this from Unassigned to In review in DEVS Jun 10, 2025
Copy link
Contributor

@GuiMacielPereira GuiMacielPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are my suggestions regarding release notes, although they're more of a stylistic choice.

@github-project-automation github-project-automation bot moved this from In review to Waiting response in DEVS Jun 10, 2025
SilkeSchomann and others added 2 commits June 10, 2025 10:47
…466.rst

Co-authored-by: Gui Maciel Pereira <80104863+GuiMacielPereira@users.noreply.github.com>
…s/39466.rst

Co-authored-by: Gui Maciel Pereira <80104863+GuiMacielPereira@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Waiting response to Approved in DEVS Jun 10, 2025
@thomashampson thomashampson self-assigned this Jun 11, 2025
@thomashampson thomashampson merged commit bd31697 into release-next Jun 11, 2025
10 checks passed
@thomashampson thomashampson deleted the mslice_release_notes_6_13 branch June 11, 2025 15:14
@github-project-automation github-project-automation bot moved this from Approved to Merged in DEVS Jun 11, 2025
@sf1919 sf1919 moved this from Ready for Review to Done in v6.13 Release Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS: Excitations/Vesuvio Issue and pull requests relating to Excitiations/Vesuvio at ISIS
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants