Skip to content

Conversation

cailafinn
Copy link
Contributor

@cailafinn cailafinn commented Jun 10, 2025

Description of work

Summary of work

Create the main release note files for the release of 6.13.

There is no associated issue.

To test:

  1. Build the docs-html target.
  2. Open the generated html files in a browser and check there aren't formatting/build errors/warnings.

This does not require release notes because it is release notes


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn changed the base branch from main to release-next June 10, 2025 10:27
@cailafinn cailafinn added the Documentation Issues and pull requests related to documentation label Jun 10, 2025
@cailafinn cailafinn added the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label Jun 10, 2025
@cailafinn cailafinn added this to the Release 6.13 milestone Jun 10, 2025
@cailafinn cailafinn moved this to Ready for Review in v6.13 Release Jun 10, 2025
@cailafinn cailafinn marked this pull request as ready for review June 10, 2025 10:32
@peterfpeterson peterfpeterson self-requested a review June 10, 2025 12:14
Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built it locally and clicked on random links in the release notes

@SilkeSchomann
Copy link
Contributor

I couldn't find any formatting problems or build errors/warnings either.

@SilkeSchomann SilkeSchomann merged commit bd31d74 into mantidproject:release-next Jun 10, 2025
10 checks passed
@cailafinn cailafinn deleted the 6-13_release_notes branch June 10, 2025 15:37
@sf1919 sf1919 moved this from Ready for Review to Done in v6.13 Release Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants