-
Notifications
You must be signed in to change notification settings - Fork 128
Edit v6.13.0 Diffraction Release Notes #39503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit v6.13.0 Diffraction Release Notes #39503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few changes I'm requesting that be made. Otherwise formatting, spelling and grammer are all good.
I see that some PRs have links to the GitHub issues relating to them. Either we need to do that with all release notes or we need to remove the links from these ones. I would prefer consistency.
2884702
to
d420a2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for the changes I requested. I think it looks much better.
0f41cea
into
mantidproject:release-next
Description of work
Summary of work
Diffraction release notes for v6.13.0.
Refs #39471
To test:
Formatting and no build warnings.
cmake --build . --target docs-html
open docs/html/release/v6.13.0/diffraction.html
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.