Skip to content

Conversation

cailafinn
Copy link
Contributor

Description of work

Summary of work

Diffraction release notes for v6.13.0.

Refs #39471

To test:

Formatting and no build warnings.

  1. cmake --build . --target docs-html
  2. open docs/html/release/v6.13.0/diffraction.html

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn added this to the Release 6.13 milestone Jun 18, 2025
@cailafinn cailafinn added the Documentation Issues and pull requests related to documentation label Jun 18, 2025
@cailafinn cailafinn marked this pull request as ready for review June 18, 2025 11:34
@sf1919 sf1919 moved this to Ready for Review in v6.13 Release Jun 18, 2025
@sf1919 sf1919 self-assigned this Jun 18, 2025
@cailafinn cailafinn linked an issue Jun 18, 2025 that may be closed by this pull request
7 tasks
Copy link
Contributor

@sf1919 sf1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few changes I'm requesting that be made. Otherwise formatting, spelling and grammer are all good.

I see that some PRs have links to the GitHub issues relating to them. Either we need to do that with all release notes or we need to remove the links from these ones. I would prefer consistency.

@cailafinn cailafinn force-pushed the 39471_diffraction_notes branch from 2884702 to d420a2b Compare June 19, 2025 12:09
Copy link
Contributor

@sf1919 sf1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the changes I requested. I think it looks much better.

@sf1919 sf1919 moved this from Ready for Review to Review Approved in v6.13 Release Jun 19, 2025
@RichardWaiteSTFC RichardWaiteSTFC merged commit 0f41cea into mantidproject:release-next Jun 19, 2025
10 checks passed
@cailafinn cailafinn moved this from Review Approved to Done in v6.13 Release Jun 20, 2025
@cailafinn cailafinn deleted the 39471_diffraction_notes branch June 24, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Release Notes Need Editing for v6.13.0
3 participants