Skip to content

Conversation

cailafinn
Copy link
Contributor

@cailafinn cailafinn commented Jun 18, 2025

Description of work

Summary of work

Release notes for small sets from a few related science areas.

Refs #39471

To test:

Build & open docs files.

This does not require release notes because ...y'know.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn added this to the Release 6.13 milestone Jun 18, 2025
@cailafinn cailafinn added the Documentation Issues and pull requests related to documentation label Jun 18, 2025
@cailafinn cailafinn moved this to Ready for Review in v6.13 Release Jun 18, 2025
@cailafinn cailafinn marked this pull request as ready for review June 18, 2025 15:37
@cailafinn cailafinn linked an issue Jun 18, 2025 that may be closed by this pull request
7 tasks
@sf1919 sf1919 self-assigned this Jun 19, 2025
Copy link
Contributor

@sf1919 sf1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again great work. Pages all build correctly locally and just a couple of minor changes to request. Otherwise looks good.

- :ref:`algm-VesuvioPeakPrediction` now supports a ``Classical`` option. It is used to estimate the lower bounds of the
width of the Neutron Compton Profiles when running analysis routines.
- :ref:`ISIS Energy Transfer tab <ISISEnergyTransfer>` now supports an output label that is appended to the output name
and doesn't override previous outputs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
and doesn't override previous outputs
and doesn't override previous outputs.



Algorithms
----------

New features
############
- :ref:`BayesQuasi2 <algm-BayesQuasi2>` and :ref:`BayesStretch2 <algm-BayesStretch2>` are now available for all Mantid users now that ``quickbayes`` v1.0.2 is installed as a ``mantid`` dependency via Conda.
- :ref:`BayesQuasi2 <algm-BayesQuasi2>` and :ref:`BayesStretch2 <algm-BayesStretch2>` are now available for all Mantid
users now that ``quickbayes`` v1.0.2 is installed as a ``mantid`` dependency via Conda.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
users now that ``quickbayes`` v1.0.2 is installed as a ``mantid`` dependency via Conda.
users now that ``quickbayes`` v1.0.2 is installed as a ``mantid`` dependency via conda.

sf1919
sf1919 previously approved these changes Jun 23, 2025
Copy link
Contributor

@sf1919 sf1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making those changes :)

@sf1919 sf1919 moved this from Ready for Review to Review Approved in v6.13 Release Jun 23, 2025
@jclarkeSTFC jclarkeSTFC self-assigned this Jun 23, 2025
@jclarkeSTFC
Copy link
Contributor

Base branch release-next instead of main?

@cailafinn cailafinn changed the base branch from main to release-next June 23, 2025 16:14
@cailafinn cailafinn dismissed sf1919’s stale review June 23, 2025 16:14

The base branch was changed.

@jclarkeSTFC jclarkeSTFC merged commit c0a06f1 into mantidproject:release-next Jun 24, 2025
10 checks passed
@sf1919 sf1919 moved this from Review Approved to Done in v6.13 Release Jun 24, 2025
@cailafinn cailafinn deleted the 39471_direct_release branch June 24, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Release Notes Need Editing for v6.13.0
3 participants