Skip to content

Conversation

SilkeSchomann
Copy link
Contributor

Description of work

The latest released version of MSlice is version 2.12. This PRs updates the Conda recipe for Mantid to allow using the latest version of MSlice.

There is no associated issue.

To test:

Run the following command to satisfy yourself that pinning mslice=2.12 will pick up the latest MSlice version:
conda create -n mslice_nightly_test -c mantid mslice=2.12 --dry-run

This does not require release notes because all release notes for MSlice have already been added beforehand.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@SilkeSchomann SilkeSchomann added this to the Release 6.13 milestone Jun 25, 2025
@SilkeSchomann SilkeSchomann added the High Priority An issue or pull request that if not addressed is severe enough to postponse a release. label Jun 25, 2025
Copy link
Contributor

@sf1919 sf1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fairly straight forward change required for release.

@sf1919 sf1919 moved this to Ready for Review in v6.13 Release Jun 25, 2025
@sf1919 sf1919 moved this from Ready for Review to Review Approved in v6.13 Release Jun 25, 2025
@sf1919 sf1919 self-assigned this Jun 25, 2025
@jclarkeSTFC jclarkeSTFC self-assigned this Jun 25, 2025
@jclarkeSTFC jclarkeSTFC merged commit f656c1e into release-next Jun 25, 2025
10 checks passed
@jclarkeSTFC jclarkeSTFC deleted the mslice_release_2_12 branch June 25, 2025 14:14
@cailafinn cailafinn moved this from Review Approved to Done in v6.13 Release Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants