Skip to content

Conversation

searscr
Copy link
Contributor

@searscr searscr commented Jun 25, 2025

Description of work

Similar to #39348, This PR aims to fix a performance issue where EventList::operator+=() was being used inefficiently. This caused Mantid to hang due to repeated memory reallocation as each EventList was appended. This fix improves performance by correctly preallocating memory based on the eventType of each EventList, ensuring the appropriate storage structure is reserved up front.

Relates to EWM12012


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@searscr searscr added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels Jun 25, 2025
@searscr searscr added this to the Release 6.13 milestone Jun 25, 2025
@sf1919 sf1919 moved this to Ready for Review in v6.13 Release Jun 26, 2025
@KedoKudo KedoKudo merged commit 06a461a into release-next Jun 26, 2025
10 checks passed
@KedoKudo KedoKudo deleted the EWM12012_SumSpectraDefect branch June 26, 2025 13:20
@cailafinn cailafinn moved this from Ready for Review to Done in v6.13 Release Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants