Skip to content

Conversation

thomashampson
Copy link
Contributor

This was suppsioed to be merged into release-next and not main.

There is no associated issue.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

#### Summary of work
Tidies up release notes with images and fixed headings.
@thomashampson thomashampson added this to the Release 6.13 milestone Jul 1, 2025
@thomashampson thomashampson added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Documentation Issues and pull requests related to documentation labels Jul 1, 2025
@thomashampson thomashampson marked this pull request as ready for review July 1, 2025 08:59
@thomashampson thomashampson changed the title Final Tidy for v6.13.0 release notes - release-next Final tidy for v6.13.0 release notes - release-next Jul 1, 2025
Copy link
Contributor

@sf1919 sf1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing as this is the same as the PR the one that went into main and I approved that - I am happy to approve this one.

@SilkeSchomann SilkeSchomann self-assigned this Jul 1, 2025
@SilkeSchomann SilkeSchomann merged commit a20a2f0 into release-next Jul 1, 2025
10 checks passed
@SilkeSchomann SilkeSchomann deleted the release-notes-tidy-6-13 branch July 1, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Issues and pull requests related to documentation High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants