Skip to content

Conversation

warunawickramasingha
Copy link
Contributor

Description of work

MSlice is turned into an optional dependency of mantidworkbench. However, mslice would still be installed explicitly in IDAaaS and inside standalone packages.

Fixes #39237.

To test:

  1. Run build_packages_from_branch pipeline for this branch with parameters as BUILD_DEVEL=none, BUILD_PACKAGE=all, PUBLISH_TO_ANACONDA=true, ANACONDA_CHANNEL_LABEL=mslice_unstable, BRANCH_NAME=39237_making_mslice_optinal_dependancy
  2. Install the resulting conda packages and standalone packages,
  3. Verify that MSlice is not included in conda package
  4. Verify MSlice is included in the standalone installer for Windows, Linux and MacOS
  5. Verify MSlice is installed in IDAaaS

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@warunawickramasingha warunawickramasingha changed the title 39237 making mslice optinal dependancy MSlice is made and optional dependency of mantidworkbench for conda installs Jul 16, 2025
@warunawickramasingha warunawickramasingha added this to the Release 6.14 milestone Jul 16, 2025
@warunawickramasingha
Copy link
Contributor Author

warunawickramasingha commented Jul 17, 2025

Note:
This PR cannot be tested until changes from the below PRs are merged into the main

  1. Remove link between muon and curvefitting libs #39656
  2. Avoid Linux standalone launching error #39670

@warunawickramasingha warunawickramasingha added Maintenance Unassigned issues to be addressed in the next maintenance period. ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions Dependencies Pull requests that update a dependency file labels Jul 17, 2025
@warunawickramasingha warunawickramasingha added the ISIS: Excitations/Vesuvio Issue and pull requests relating to Excitiations/Vesuvio at ISIS label Jul 17, 2025
@thomashampson
Copy link
Contributor

I have created a PR to ensure mslice is always available on IDAaaS.

@thomashampson thomashampson force-pushed the 39237_making_mslice_optinal_dependancy branch from 8219eef to 1530e97 Compare July 22, 2025 13:32
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested a linux build ina conda environment and standalone install on IDAaaS and the behaviour is as expected:

  • mslice is not installed when I install mantidworkbench in a conda environment
  • mslice is rpesent in the standalone installation
    I have also checked that the run export (the mslice pinning) works as expected.

I have one small comment on the clarity of the release notes.

…s/39237.rst

Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk>
Copy link
Contributor

@thomashampson thomashampson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tested (see above), and happy with the release notes.

@SilkeSchomann SilkeSchomann self-assigned this Jul 23, 2025
@SilkeSchomann SilkeSchomann enabled auto-merge (squash) July 23, 2025 09:22
@SilkeSchomann SilkeSchomann merged commit 282a683 into main Jul 23, 2025
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 39237_making_mslice_optinal_dependancy branch July 23, 2025 10:01
peterfpeterson pushed a commit to peterfpeterson/mantid that referenced this pull request Jul 23, 2025
…nstalls (mantidproject#39675)

MSlice is turned into an optional dependency of mantidworkbench.
However, mslice would still be installed explicitly in IDAaaS and inside
standalone packages.
peterfpeterson added a commit that referenced this pull request Jul 23, 2025
…nstalls (#39723)

This is a version of #39675 into `ornl-next`

Co-authored-by: Waruna Priyankara J A Wickramasingha <142818102+warunawickramasingha@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file ISIS: Core Issue and pull requests at ISIS that relate to Core features and functions ISIS: Excitations/Vesuvio Issue and pull requests relating to Excitiations/Vesuvio at ISIS Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make mslice an optional dependency of mantidworkbench
3 participants