-
Notifications
You must be signed in to change notification settings - Fork 128
MSlice is made and optional dependency of mantidworkbench for conda installs #39675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: |
I have created a PR to ensure mslice is always available on IDAaaS. |
8219eef
to
1530e97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested a linux build ina conda environment and standalone install on IDAaaS and the behaviour is as expected:
- mslice is not installed when I install mantidworkbench in a conda environment
- mslice is rpesent in the standalone installation
I have also checked that the run export (the mslice pinning) works as expected.
I have one small comment on the clarity of the release notes.
docs/source/release/v6.14.0/Direct_Geometry/MSlice/New_features/39237.rst
Outdated
Show resolved
Hide resolved
…s/39237.rst Co-authored-by: thomashampson <thomas.hampson@stfc.ac.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tested (see above), and happy with the release notes.
…nstalls (mantidproject#39675) MSlice is turned into an optional dependency of mantidworkbench. However, mslice would still be installed explicitly in IDAaaS and inside standalone packages.
Description of work
MSlice is turned into an optional dependency of mantidworkbench. However, mslice would still be installed explicitly in IDAaaS and inside standalone packages.
Fixes #39237.
To test:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.