-
Notifications
You must be signed in to change notification settings - Fork 128
Allow Nexus to make nested groups with same name #39686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs release notes. I can still make it fail if I change the last two lines to
RenameWorkspace(out_ws, OutputWorkspace="data/data")
SaveNXSPE("data/data", file_path,Psi=32)
// check that we can make '/test_group/test_group' | ||
TS_ASSERT_THROWS_NOTHING(file.makeGroup(grp, "NXsample", true)); | ||
TS_ASSERT_THROWS_NOTHING(file.makeGroup(grp, "NXdata", true)); | ||
TS_ASSERT_EQUALS(file.getPath(), "/test_group/test_group"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am pretty certain, for a workspace named "data"
, that this line will actually create a a dataset called "/data/data/data"
. We need a test for this inside SaveNXSETest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are correct, it is opening /data/data/data
. Would a nominal test with the workspace named data
be sufficient?
Release notes for 6.13.1 will be added at the end in a spearate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Andrei still approves. Thank you for adding the more sensible error message and new tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a quick question about the test that's been added:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating that test. Looks good to me now.
Description of work
A bug was found in
SaveNXSPE
where an exception would be raised if trying to create and open a group with the same name as the group you are in. For example creating the group/something/something
would raise an exception. This adds a flag for opening data that will allow us to open groups with the same name without corrupting the Nexus address if we try to open the same data multiple times.Fixes #39672 .
Relates to EWM Defect 12236
To test:
The following script should run and successfully save the file.
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.