Skip to content

Conversation

RichardWaiteSTFC
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC commented Sep 19, 2025

Description of work

Doc test was failing

document: algorithms/PoldiAutoCorrelation-v6
--------------------------------------------
# stuff...
Expected:
    The workspace contains 448 spectra.
    The correlation spectrum has 2460 bins.
Got:
    The workspace contains 448 spectra.
    The correlation spectrum has 2833 bins.
**********************************************************************
1 items had failures:
   1 of   1 in POLDI_silicon_autocorr
1 tests in 1 items.
0 passed and 1 failed.
***Test Failed*** 1 failures.

This is after a bug was fixed in max arrival time calculation in PR #39912 in commit 704e68a
The value now matches the unit test value.

To test:

(1) Run doc tests locally

No release note required as not user facing change


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

This is after a bug was fixed in max arrival time calculation in PR #39912.
The value now matches the unit test value.
@jclarkeSTFC jclarkeSTFC enabled auto-merge (squash) September 19, 2025 07:53
@jclarkeSTFC jclarkeSTFC merged commit 2ea8ecf into main Sep 19, 2025
5 of 11 checks passed
@jclarkeSTFC jclarkeSTFC deleted the fix_poldi_doc_test branch September 19, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants