Add ability to turn off some of the local repository mirrors #39957
+28
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than relying on network and such to fail quickly from servers that cannot be seen, add options to only include selected local mirrors. Since this happens at the cmake configuration stage, only the desired mirrors will be added to the list to search. The new mechanism defaults to using all mirrors.
Nothing was changed in buildscripts because it requires a mechanism to determine which build server is being used.
There is no associated issue.
To test:
Try the various options
all
,none
,ornl
, andral
and look for the cmake message about which mirrors are used. One can also search theCMakeCache.txt
for the value ofExternalData_URL
.Reviewer
Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.
As per the review guidelines:
Gatekeeper
As per the gatekeeping guidelines: