Skip to content

Conversation

peterfpeterson
Copy link
Member

@peterfpeterson peterfpeterson commented Sep 19, 2025

Rather than relying on network and such to fail quickly from servers that cannot be seen, add options to only include selected local mirrors. Since this happens at the cmake configuration stage, only the desired mirrors will be added to the list to search. The new mechanism defaults to using all mirrors.

Nothing was changed in buildscripts because it requires a mechanism to determine which build server is being used.

There is no associated issue.

To test:

Try the various options all, none, ornl, and ral and look for the cmake message about which mirrors are used. One can also search the CMakeCache.txt for the value of ExternalData_URL.


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@peterfpeterson peterfpeterson added this to the Release 6.14 milestone Sep 19, 2025
@peterfpeterson peterfpeterson added Maintenance Unassigned issues to be addressed in the next maintenance period. DevOps Issues and pull requests related to DevOps labels Sep 19, 2025
@peterfpeterson peterfpeterson marked this pull request as ready for review September 19, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Issues and pull requests related to DevOps Maintenance Unassigned issues to be addressed in the next maintenance period.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant