Skip to content

Conversation

adriazalvarez
Copy link
Contributor

@adriazalvarez adriazalvarez commented Sep 22, 2025

Description of work

This is a maintenance issue. Many of the tests for the sans polarization corrections algorithms can share similar test data, however every tests for each polarization algorithm has its own set of helper functions to create a workspace group suitable for polarization algorithms. I have tried to unify all this helper functions into a new file PolarizationCorrectionsTestsUtils, which is already recycled from a helper file used in the analyser efficiency tests.
The two main changes are the inclusion of a helper function createPolarizedTestGroup that can be used in all the polarization correction tests and a struct to hold the main parameters of the workspaces and efficiency functions.

Note: I have set the release to 6.15 as there is no hurry to get this reviewed before code freeze for 6.14 if there are more important PRs to review.

No associated issue.

To test:

  • All tests are passing.

Release notes no necessary as it is internal change for tests only


Reviewer

Your comments will be used as part of the gatekeeper process. Comment clearly on what you have checked and tested during your review. Provide an audit trail for any changes requested.

As per the review guidelines:

  • Is the code of an acceptable quality? (Code standards/GUI standards)
  • Has a thorough functional test been performed? Do the changes handle unexpected input/situations?
  • Are appropriately scoped unit and/or system tests provided?
  • Do the release notes conform to the guidelines and describe the changes appropriately?
  • Has the relevant (user and developer) documentation been added/updated?

Gatekeeper

As per the gatekeeping guidelines:

  • Has a thorough first line review been conducted, including functional testing?
  • At a high-level, is the code quality sufficient?
  • Are the base, milestone and labels correct?

@adriazalvarez adriazalvarez added this to the Release 6.15 milestone Sep 22, 2025
@adriazalvarez adriazalvarez added the SANS Issues and pull requests related to SANS label Sep 22, 2025
@adriazalvarez adriazalvarez added the Maintenance Unassigned issues to be addressed in the next maintenance period. label Sep 22, 2025
@adriazalvarez adriazalvarez moved this from Done to Ready for Review in Mantid Maintenance Sep 24, 2025
@adriazalvarez adriazalvarez marked this pull request as ready for review September 24, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Unassigned issues to be addressed in the next maintenance period. SANS Issues and pull requests related to SANS
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant